Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 3000783002: Revert of ApkHelper: Add GetViewActivityName(). Make GetActivityName() more strict (Closed)

Created:
3 years, 4 months ago by jbudorick
Modified:
3 years, 4 months ago
Reviewers:
agrieve
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of ApkHelper: Add GetViewActivityName(). Make GetActivityName() more strict (patchset #2 id:20001 of https://codereview.chromium.org/2994053002/ ) Reason for revert: breaking the roller: https://chromium-review.googlesource.com/c/612264 Original issue's description: > ApkHelper: Add GetViewActivityName(). Make GetActivityName() more strict > > GetActivityName() now looks for the launcher activity rather than just > returning the first activity. > > BUG=chromium:749239 > > Review-Url: https://codereview.chromium.org/2994053002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8a1ca7ff3ad0a5c4af93ba5b018c2c7d74cc276f TBR=agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:749239 Review-Url: https://codereview.chromium.org/3000783002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/5925bf00df4e964b05683662d86fe05606aa1ba5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -101 lines) Patch
M devil/devil/android/apk_helper.py View 5 chunks +15 lines, -56 lines 0 comments Download
M devil/devil/android/apk_helper_test.py View 5 chunks +13 lines, -45 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jbudorick
Created Revert of ApkHelper: Add GetViewActivityName(). Make GetActivityName() more strict
3 years, 4 months ago (2017-08-11 14:06:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3000783002/1
3 years, 4 months ago (2017-08-11 14:06:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/5925bf00df4e964b05683662d86fe05606aa1ba5
3 years, 4 months ago (2017-08-11 14:06:43 UTC) #6
agrieve
3 years, 4 months ago (2017-08-11 14:55:33 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2995763002/ by agrieve@chromium.org.

The reason for reverting is: will fix.

Powered by Google App Engine
This is Rietveld 408576698