ApkHelper: Add GetViewActivityName(). Make GetActivityName() more strict

ApkHelper: Add GetViewActivityName(). Make GetActivityName() more strict

GetActivityName() now looks for the launcher activity rather than just
returning the first activity.

BUG=chromium:749239
Review-Url: https://codereview.chromium.org/2994053002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8a1ca7ff3ad0a5c4af93ba5b018c2c7d74cc276f

[agrieve, 2017-08-10 02:25:31]

Description was changed from

==========
ApkHelper: Add GetViewActivityName(). Make GetActivityName() more strict

GetActivityName() now looks for the launcher activity rather than just
returning the first activity.

BUG=chromium:749239
==========

to

==========
ApkHelper: Add GetViewActivityName(). Make GetActivityName() more strict

GetActivityName() now looks for the launcher activity rather than just
returning the first activity.

BUG=chromium:749239
==========

[agrieve, 2017-08-10 02:25:31]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2017-08-10 02:25:43]

On 2017/08/10 02:25:31, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:jbudorick@chromium.org

🚅

[jbudorick, 2017-08-10 13:12:50]

lgtm w/ nits

https://codereview.chromium.org/2994053002/diff/1/devil/devil/android/apk_hel...
File devil/devil/android/apk_helper.py (right):

https://codereview.chromium.org/2994053002/diff/1/devil/devil/android/apk_hel...
devil/devil/android/apk_helper.py:80: def _ParseNumericKey(obj, key, default):
nit: default=0?

https://codereview.chromium.org/2994053002/diff/1/devil/devil/android/apk_hel...
devil/devil/android/apk_helper.py:84: return int(val, 0)
nit: return int(obj.get(key, default), 0)

?

[agrieve, 2017-08-10 14:22:00]

https://codereview.chromium.org/2994053002/diff/1/devil/devil/android/apk_hel...
File devil/devil/android/apk_helper.py (right):

https://codereview.chromium.org/2994053002/diff/1/devil/devil/android/apk_hel...
devil/devil/android/apk_helper.py:80: def _ParseNumericKey(obj, key, default):
On 2017/08/10 13:12:50, jbudorick wrote:
> nit: default=0?

Done.

https://codereview.chromium.org/2994053002/diff/1/devil/devil/android/apk_hel...
devil/devil/android/apk_helper.py:84: return int(val, 0)
On 2017/08/10 13:12:50, jbudorick wrote:
> nit: return int(obj.get(key, default), 0)
> 
> ?

"int() can't convert non-string with explicit base"

[agrieve, 2017-08-10 14:24:19]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-08-10 14:24:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2994053002/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2017-08-10 14:24:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-10 14:58:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1502375059307090,
"parent_rev": "18709dd6bd88aee18994e1570754e0a1bb92bea4", "commit_rev":
"8a1ca7ff3ad0a5c4af93ba5b018c2c7d74cc276f"}

[commit-bot: I haz the power, 2017-08-10 14:58:39]

Description was changed from

==========
ApkHelper: Add GetViewActivityName(). Make GetActivityName() more strict

GetActivityName() now looks for the launcher activity rather than just
returning the first activity.

BUG=chromium:749239
==========

to

==========
ApkHelper: Add GetViewActivityName(). Make GetActivityName() more strict

GetActivityName() now looks for the launcher activity rather than just
returning the first activity.

BUG=chromium:749239

Review-Url: https://codereview.chromium.org/2994053002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-08-10 14:58:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[jbudorick, 2017-08-11 14:06:24]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/3000783002/ by jbudorick@chromium.org.

The reason for reverting is: breaking the roller:
https://chromium-review.googlesource.com/c/612264.