Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2995493002: [impl/memory] Enforce named tasks during txn. (Closed)

Created:
3 years, 4 months ago by dnj
Modified:
3 years, 4 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

[impl/memory] Enforce named tasks during txn. Task queue does not allow named tasks to be added in a transaction. Enforce this in "impl/memory" so that tests will properly fail when this is attempted. Also update PRESUBMIT so that it properly validates the new license header format. BUG=None TEST=unit Review-Url: https://codereview.chromium.org/2995493002 Committed: https://github.com/luci/gae/commit/6ba0ca9e5e64d0543541c0c460b74abb9ddbf8e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -13 lines) Patch
M PRESUBMIT.py View 2 chunks +23 lines, -10 lines 0 comments Download
M impl/memory/taskqueue.go View 3 chunks +7 lines, -3 lines 0 comments Download
M impl/memory/taskqueue_test.go View 3 chunks +14 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
dnj
PTAL
3 years, 4 months ago (2017-08-04 01:55:12 UTC) #2
iannucci
lgtm huh I thought I already checked for this... werid
3 years, 4 months ago (2017-08-04 01:59:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2995493002/1
3 years, 4 months ago (2017-08-04 02:19:47 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-04 02:24:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/6ba0ca9e5e64d0543541c0c460b74abb9ddbf8e1

Powered by Google App Engine
This is Rietveld 408576698