[dsreadonly] Add read-only datastore filter.

[dsreadonly] Add read-only datastore filter.

Add a read-only datastore filter, which will error if a mutation
operation is performed on the datastore.

BUG=None
TEST=unit

Review-Url: https://codereview.chromium.org/2993033002
Committed: https://github.com/luci/gae/commit/b485cceb10656fa5e30a8d8840f7ab4e67a899b4

[dnj, 2017-08-04 02:19:49]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org

[dnj, 2017-08-04 02:19:49]

PTAL!

[dnj, 2017-08-04 02:23:26]

The CQ bit was checked by dnj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-04 02:23:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-04 02:26:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-04 02:26:47]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-08-04 02:28:50]

lgtm

https://codereview.chromium.org/2993033002/diff/1/filter/dsreadonly/rds.go
File filter/dsreadonly/rds.go (right):

https://codereview.chromium.org/2993033002/diff/1/filter/dsreadonly/rds.go#ne...
filter/dsreadonly/rds.go:15: // Package dsreadonly implements a filter that
enforces read-only accesses to
I would maybe make the package 'readonly' and just implement DS for now. Making
readonly for the other services would be trivial, and it would be better to have
readonly.FilterRDS + readonly.FilterMC rather than dsreadonly.FilterRDS +
mcreadonly.FilterMC.

[dnj, 2017-08-04 02:50:33]

https://codereview.chromium.org/2993033002/diff/1/filter/dsreadonly/rds.go
File filter/dsreadonly/rds.go (right):

https://codereview.chromium.org/2993033002/diff/1/filter/dsreadonly/rds.go#ne...
filter/dsreadonly/rds.go:15: // Package dsreadonly implements a filter that
enforces read-only accesses to
On 2017/08/04 02:28:50, iannucci wrote:
> I would maybe make the package 'readonly' and just implement DS for now.
Making
> readonly for the other services would be trivial, and it would be better to
have
> readonly.FilterRDS + readonly.FilterMC rather than dsreadonly.FilterRDS +
> mcreadonly.FilterMC.

TBH I can't think of a case where we'd ever want read-only memcache :x

[dnj, 2017-08-04 15:17:19]

On 2017/08/04 02:50:33, dnj wrote:
> https://codereview.chromium.org/2993033002/diff/1/filter/dsreadonly/rds.go
> File filter/dsreadonly/rds.go (right):
> 
>
https://codereview.chromium.org/2993033002/diff/1/filter/dsreadonly/rds.go#ne...
> filter/dsreadonly/rds.go:15: // Package dsreadonly implements a filter that
> enforces read-only accesses to
> On 2017/08/04 02:28:50, iannucci wrote:
> > I would maybe make the package 'readonly' and just implement DS for now.
> Making
> > readonly for the other services would be trivial, and it would be better to
> have
> > readonly.FilterRDS + readonly.FilterMC rather than dsreadonly.FilterRDS +
> > mcreadonly.FilterMC.
> 
> TBH I can't think of a case where we'd ever want read-only memcache :x

I am realizing now that one can apply filters selectively, so no harm in this
rename.

[dnj, 2017-08-04 15:17:23]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-08-04 15:17:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2993033002/#ps20001
(title: "Rename to "readonly"")

[commit-bot: I haz the power, 2017-08-04 15:17:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-04 15:20:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1501859843695740,
"parent_rev": "6ba0ca9e5e64d0543541c0c460b74abb9ddbf8e1", "commit_rev":
"b485cceb10656fa5e30a8d8840f7ab4e67a899b4"}

[commit-bot: I haz the power, 2017-08-04 15:20:41]

Description was changed from

==========
[dsreadonly] Add read-only datastore filter.

Add a read-only datastore filter, which will error if a mutation
operation is performed on the datastore.

BUG=None
TEST=unit
==========

to

==========
[dsreadonly] Add read-only datastore filter.

Add a read-only datastore filter, which will error if a mutation
operation is performed on the datastore.

BUG=None
TEST=unit

Review-Url: https://codereview.chromium.org/2993033002
Committed:
https://github.com/luci/gae/commit/b485cceb10656fa5e30a8d8840f7ab4e67a899b4
==========

[commit-bot: I haz the power, 2017-08-04 15:20:42]

Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/b485cceb10656fa5e30a8d8840f7ab4e67a899b4