[impl/memory] Enforce named tasks during txn.

impl/memory/taskqueue_test.go

 // Copyright 2015 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 338 matching lines @@
                                         So(tq.Add(c, "", tasks...), ShouldBeNil)
                                         So(len(tqt.GetScheduledTasks()["default"]), ShouldEqual, 1)
                                         So(len(tqt.GetTransactionTasks()["default"]), ShouldEqual, 3)
                                         return nil
                                 }, nil), ShouldBeNil)
                                 So(len(tqt.GetScheduledTasks()["default"]), ShouldEqual, 4)
                                 So(len(tqt.GetTransactionTasks()["default"]), ShouldEqual, 0)
                         })
 
                         Convey("unless you add too many things", func() {
+                                t.Name = ""
+
                                 So(ds.RunInTransaction(c, func(c context.Context) error {
                                         for i := 0; i < 5; i++ {
                                                 So(tq.Add(c, "", t.Duplicate()), ShouldBeNil)
                                         }
                                         So(tq.Add(c, "", t).Error(), ShouldContainSubstring, "BAD_REQUEST")
                                         return nil
                                 }, nil), ShouldBeNil)
                         })
 
                         Convey("unless you Add to a bad queue", func() {
+                                t.Name = ""
+
                                 So(ds.RunInTransaction(c, func(c context.Context) error {
                                         So(tq.Add(c, "meat", t).Error(), ShouldContainSubstring, "UNKNOWN_QUEUE")
 
                                         Convey("unless you add it!", func() {
                                                 tq.Raw(c).GetTestable().CreateQueue("meat")
                                                 So(tq.Add(c, "meat", t), ShouldBeNil)
                                         })
 
                                         return nil
                                 }, nil), ShouldBeNil)
                         })
 
+                        Convey("unless the task is named", func() {
+                                So(ds.RunInTransaction(c, func(c context.Context) error {
+                                        err := tq.Add(c, "", t) // Note: "t" has a Name from initial Add.
+                                        So(err, ShouldNotBeNil)
+                                        So(err.Error(), ShouldContainSubstring, "INVALID_TASK_NAME")
+
+                                        return nil
+                                }, nil), ShouldBeNil)
+                        })
+
                         Convey("No other features are available, however", func() {
                                 So(ds.RunInTransaction(c, func(c context.Context) error {
                                         So(tq.Delete(c, "", t).Error(), ShouldContainSubstring, "cannot DeleteMulti from a transaction")
                                         So(tq.Purge(c, "").Error(), ShouldContainSubstring, "cannot Purge from a transaction")
                                         _, err := tq.Stats(c, "")
                                         So(err.Error(), ShouldContainSubstring, "cannot Stats from a transaction")
                                         return nil
                                 }, nil), ShouldBeNil)
                         })
 
@@ skipping 574 matching lines @@
                                 leased, err := tq.LeaseByTag(c, 100, "pull", time.Minute, "")
                                 So(err, ShouldBeNil)
                                 So(len(leased), ShouldEqual, 5)
                                 for i := 0; i < 5; i++ {
                                         So(leased[i].Name, ShouldEqual, fmt.Sprintf("task-%d", i))
                                 }
                         })
                 })
         })
 }