Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2993793004: [scheduler]: ACLs phase 2 - warn if Job/Trigger don't have ACLs. (Closed)

Created:
3 years, 4 months ago by tandrii(chromium)
Modified:
3 years, 4 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M scheduler/appengine/catalog/catalog.go View 2 chunks +8 lines, -0 lines 0 comments Download
M scheduler/appengine/catalog/catalog_test.go View 2 chunks +20 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
tandrii(chromium)
3 years, 4 months ago (2017-08-07 13:30:04 UTC) #1
Vadim Sh.
lgtm
3 years, 4 months ago (2017-08-07 22:54:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2993793004/1
3 years, 4 months ago (2017-08-08 12:52:32 UTC) #8
commit-bot: I haz the power
3 years, 4 months ago (2017-08-08 12:57:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/84692af28c1726ba97d84dde6ec5bfb691add08e

Powered by Google App Engine
This is Rietveld 408576698