[scheduler]: ACLs phase 2 - warn if Job/Trigger don't have ACLs.

scheduler/appengine/catalog/catalog.go

 // Copyright 2015 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 265 matching lines @@
                 }
                 flavor := JobFlavorTriggered
                 if schedule != "triggered" {
                         flavor = JobFlavorPeriodic
                 }
                 acls, err := acl.ValidateTaskAcls(knownAclSets, job.GetAclSets(), job.GetAcls())
                 if err != nil {
                         logging.Errorf(c, "Failed to compute task ACLs: %s/%s: %s", projectID, id, err)
                         continue
                 }
+                // TODO(tandrii): remove this once this warning stops firing.
+                if len(acls.Owners) == 0 || len(acls.Readers) == 0 {
+                        logging.Warningf(c, "Missing some ACLs on %s/%s: R=%d O=%d", projectID, id, len(acls.Owners), len(acls.Readers))
+                }
                 out = append(out, Definition{
                         JobID:       fmt.Sprintf("%s/%s", projectID, job.Id),
                         Acls:        *acls,
                         Flavor:      flavor,
                         Revision:    meta.Revision,
                         RevisionURL: revisionURL,
                         Schedule:    schedule,
                         Task:        packed,
                 })
         }
@@ skipping 19 matching lines @@
                 }
                 schedule := trigger.Schedule
                 if schedule == "" {
                         schedule = defaultTriggerSchedule
                 }
                 acls, err := acl.ValidateTaskAcls(knownAclSets, trigger.GetAclSets(), trigger.GetAcls())
                 if err != nil {
                         logging.Errorf(c, "Failed to compute task ACLs: %s/%s: %s", projectID, id, err)
                         continue
                 }
+                // TODO(tandrii): remove this once this warning stops firing.
+                if len(acls.Owners) == 0 || len(acls.Readers) == 0 {
+                        logging.Warningf(c, "Missing some ACLs on %s/%s: R=%d O=%d", projectID, id, len(acls.Owners), len(acls.Readers))
+                }
                 out = append(out, Definition{
                         JobID:       fmt.Sprintf("%s/%s", projectID, trigger.Id),
                         Acls:        *acls,
                         Flavor:      JobFlavorTrigger,
                         Revision:    meta.Revision,
                         RevisionURL: revisionURL,
                         Schedule:    schedule,
                         Task:        packed,
                 })
         }
@@ skipping 130 matching lines @@
                 field := v.Field(i)
                 if field.Type() == taskType {
                         field.Set(reflect.ValueOf(task))
                         return proto.Marshal(&wrapper)
                 }
         }
         // This can happen only if TaskDefWrapper wasn't updated when a new task type
         // was added. This is a developer's mistake, not a config mistake.
         return nil, fmt.Errorf("could not find a field of type %T in TaskDefWrapper", task)
 }