[scheduler]: ACLs phase 2 - warn if Job/Trigger don't have ACLs.

scheduler/appengine/catalog/catalog_test.go

 // Copyright 2015 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 190 matching lines @@
                         So(projects, ShouldResemble, []string{"broken", "project1", "project2"})
                 })
 
                 Convey("GetProjectJobs works", func() {
                         defs, err := cat.GetProjectJobs(ctx, "project1")
                         So(err, ShouldBeNil)
                         So(defs, ShouldResemble, []Definition{
                                 {
                                         JobID:    "project1/noop-job-1",
                                         Acls:     acl.GrantsByRole{Readers: []string{"group:all"}, Owners: []string{"group:some-admins"}},
-                                        Revision: "847cf9c217f7bad214805f3bea7a30799383940b",
+                                        Revision: "ad93dac7f33309b6e5f3b53d6206d1b9361f83db",
                                         Schedule: "*/10 * * * * * *",
                                         Task:     []uint8{0xa, 0x0},
                                 },
                                 {
                                         JobID:    "project1/noop-job-2",
                                         Acls:     acl.GrantsByRole{Readers: []string{"group:all"}, Owners: []string{"group:some-admins"}},
-                                        Revision: "847cf9c217f7bad214805f3bea7a30799383940b",
+                                        Revision: "ad93dac7f33309b6e5f3b53d6206d1b9361f83db",
                                         Schedule: "*/10 * * * * * *",
                                         Task:     []uint8{0xa, 0x0},
                                 },
                                 {
+                                        JobID:    "project1/missing-acls",
+                                        Acls:     acl.GrantsByRole{[]string{}, []string{}},
+                                        Revision: "ad93dac7f33309b6e5f3b53d6206d1b9361f83db",
+                                        Schedule: "*/5 * * * * * *",
+                                        Task:     []uint8{0xa, 0x0},
+                                },
+                                {
                                         JobID:    "project1/urlfetch-job-1",
                                         Acls:     acl.GrantsByRole{Readers: []string{"group:all"}, Owners: []string{"group:debuggers", "group:some-admins"}},
-                                        Revision: "847cf9c217f7bad214805f3bea7a30799383940b",
+                                        Revision: "ad93dac7f33309b6e5f3b53d6206d1b9361f83db",
                                         Schedule: "*/10 * * * * * *",
                                         Task:     []uint8{18, 21, 18, 19, 104, 116, 116, 112, 115, 58, 47, 47, 101, 120, 97, 109, 112, 108, 101, 46, 99, 111, 109},
                                 },
                                 {
                                         JobID:    "project1/urlfetch-job-2",
                                         Acls:     acl.GrantsByRole{Readers: []string{"group:all"}, Owners: []string{"group:some-admins"}},
-                                        Revision: "847cf9c217f7bad214805f3bea7a30799383940b",
+                                        Revision: "ad93dac7f33309b6e5f3b53d6206d1b9361f83db",
                                         Schedule: "*/10 * * * * * *",
                                         Task:     []uint8{18, 21, 18, 19, 104, 116, 116, 112, 115, 58, 47, 47, 101, 120, 97, 109, 112, 108, 101, 46, 99, 111, 109},
                                 },
                         })
 
                         // Make sure URL fetch jobs are parsed correctly and identically.
-                        newStyleDef := defs[2].Task
-                        oldStyleDef := defs[3].Task
+                        newStyleDef := defs[3].Task
+                        oldStyleDef := defs[4].Task
                         So(newStyleDef, ShouldResemble, oldStyleDef)
                         msg := messages.TaskDefWrapper{}
                         proto.Unmarshal(newStyleDef, &msg)
                         So(msg, ShouldResemble, messages.TaskDefWrapper{
                                 UrlFetch: &messages.UrlFetchTask{
                                         Url: "https://example.com",
                                 },
                         })
                 })
 
@@ skipping 115 matching lines @@
 
 job {
   id: "noop-job-3"
   schedule: "*/10 * * * * * *"
   disabled: true
 
   noop: {}
 }
 
 job {
+  id: "missing-acls"
+  schedule: "*/5 * * * * * *"
+
+  noop: {}
+}
+
+job {
   id: "urlfetch-job-1"
   schedule: "*/10 * * * * * *"
         acl_sets: "public"
         acls {
                 role: OWNER
                 granted_to: "group:debuggers"
         }
 
   url_fetch: {
     url: "https://example.com"
@@ skipping 34 matching lines @@
         "projects/project1": {
                 "scheduler.cfg": project1Cfg,
         },
         "projects/project2": {
                 "scheduler.cfg": project2Cfg,
         },
         "projects/broken": {
                 "scheduler.cfg": "broken!!!!111",
         },
 }