Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 299213002: [New Multicolumn] Cleanup: Remove redundant members. (Closed)

Created:
6 years, 7 months ago by mstensho (USE GERRIT)
Modified:
6 years, 7 months ago
CC:
blink-reviews, mstensho+blink_opera.com, blink-reviews-rendering, chromiumbugtracker_adobe.com, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@370813
Visibility:
Public.

Description

[New Multicolumn] Cleanup: Remove redundant members. RenderMultiColumnSet doesn't need to store column width and height. These are readily available from the flow thread. And the flow thread doesn't need an extra member to store column width, since it's the same as the logical width. Calculate it on the fly when we need to determine whether the flow thread will get a new width, and when actually updating the logical width. It's not expensive to calculate, and this is not a hot path. Duplicated storage can only cause confusion and do harm, anyway. Also use the CSS 2.1 terms "used" and "actual" when we need to disambiguate, rather than "computed" and nothing. Remove "computed" from some members where it didn't add any value. Those were not CSS 2.1 "computed" values, so I found it somewhat confusing and misleading. No need for columnWidth() and columnHeight() in RenderMultiColumnSet. Use pageLogicalWidth() and pageLogicalHeight() instead. No need for columnWidth() in RenderMultiColumnFlowThread either. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -92 lines) Patch
M Source/core/rendering/RenderBlockFlow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMultiColumnFlowThread.h View 2 chunks +6 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnFlowThread.cpp View 7 chunks +34 lines, -36 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.h View 5 chunks +9 lines, -16 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.cpp View 18 chunks +34 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mstensho (USE GERRIT)
This patch depends on https://codereview.chromium.org/288263002/
6 years, 7 months ago (2014-05-23 15:58:30 UTC) #1
mstensho (USE GERRIT)
6 years, 7 months ago (2014-05-27 08:11:59 UTC) #2
Julien - ping for review
lgtm after reformatting the description to be <80 characters long (see https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/rqGhY7PfkYY). I usually recommend ...
6 years, 7 months ago (2014-05-27 14:23:40 UTC) #3
mstensho (USE GERRIT)
The CQ bit was checked by mstensho@opera.com
6 years, 7 months ago (2014-05-27 14:35:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/299213002/1
6 years, 7 months ago (2014-05-27 14:35:18 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 16:00:11 UTC) #6
Message was sent while issue was closed.
Change committed as 174870

Powered by Google App Engine
This is Rietveld 408576698