[logdog] Stream view explicitly cancels request.

[logdog] Stream view explicitly cancels request.

Currently, a request, when cancelled, is ignored, but is still alllowed
to proceed. This causes HTTP requests for logs that are cancelled to
actually cancel their underlying requests.

BUG=chromium:751872
TEST=None

Review-Url: https://codereview.chromium.org/2989313002
Committed: https://github.com/luci/luci-go/commit/2dee6bcd09b0536f4e7c1a3a41331b60bcb184e0

[dnj, 2017-08-02 22:29:28]

dnj@chromium.org changed reviewers:
+ hinoka@chromium.org

[dnj, 2017-08-02 22:29:29]

PTAL

[Ryan Tseng, 2017-08-02 23:02:48]

hinoka@google.com changed reviewers:
+ hinoka@google.com

[Ryan Tseng, 2017-08-02 23:02:49]

lgtm

you probably want to add a bug to these CLs

[dnj, 2017-08-02 23:08:55]

Description was changed from

==========
[logdog] Stream view explicitly cancels request.

Currently, a request, when cancelled, is ignored, but is still alllowed
to proceed. This causes HTTP requests for logs that are cancelled to
actually cancel their underlying requests.

BUG=None
TEST=None
==========

to

==========
[logdog] Stream view explicitly cancels request.

Currently, a request, when cancelled, is ignored, but is still alllowed
to proceed. This causes HTTP requests for logs that are cancelled to
actually cancel their underlying requests.

BUG=chromium:751872
TEST=None
==========

[dnj, 2017-08-02 23:09:11]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2017-08-02 23:09:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-02 23:14:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1501715351217370, "parent_rev":
"ad913aefc7240bcad0a7d52d31345b2e181b456a", "commit_rev":
"2dee6bcd09b0536f4e7c1a3a41331b60bcb184e0"}

[commit-bot: I haz the power, 2017-08-02 23:15:00]

Description was changed from

==========
[logdog] Stream view explicitly cancels request.

Currently, a request, when cancelled, is ignored, but is still alllowed
to proceed. This causes HTTP requests for logs that are cancelled to
actually cancel their underlying requests.

BUG=chromium:751872
TEST=None
==========

to

==========
[logdog] Stream view explicitly cancels request.

Currently, a request, when cancelled, is ignored, but is still alllowed
to proceed. This causes HTTP requests for logs that are cancelled to
actually cancel their underlying requests.

BUG=chromium:751872
TEST=None

Review-Url: https://codereview.chromium.org/2989313002
Committed:
https://github.com/luci/luci-go/commit/2dee6bcd09b0536f4e7c1a3a41331b60bcb184e0
==========

[commit-bot: I haz the power, 2017-08-02 23:15:03]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/2dee6bcd09b0536f4e7c1a3a41331b60bcb184e0