Take non-default browser target location into account when attaching to it.

Take non-default browser target location into account when attaching to it.

BUG=chromium:666865
Review-Url: https://codereview.chromium.org/2989413002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0c52f6ade0f544259f977ace6c290a510502410f

[pfeldman, 2017-08-03 22:34:02]

pfeldman@chromium.org changed reviewers:
+ nednguyen@chromium.org

[nednguyen, 2017-08-03 22:35:15]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-08-03 22:35:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2017-08-03 22:37:46]

lgtm

Though can you attach BUG=chromium:<the bug id about refactoring devtool browser
target> ?

[commit-bot: I haz the power, 2017-08-03 22:38:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-03 22:38:17]

Dry run: Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[pfeldman, 2017-08-03 23:25:20]

Description was changed from

==========
Take non-default browser target location into account when attaching to it.

BUG=catapult:#
==========

to

==========
Take non-default browser target location into account when attaching to it.

BUG=chromium:666865
==========

[pfeldman, 2017-08-03 23:25:43]

Done.

[nednguyen, 2017-08-03 23:26:12]

lgtm

I think the CQ failure are flakes & not related to this CL

[nednguyen, 2017-08-03 23:26:35]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2017-08-03 23:26:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-04 00:30:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-04 00:30:58]

Try jobs failed on following builders:
  Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)

[pfeldman, 2017-08-04 00:50:25]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-08-04 00:50:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2017-08-04 01:12:22]

On 2017/08/04 00:50:28, commit-bot: I haz the power wrote:
> CQ is trying da patch.
> 
> Follow status at:
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Looks like the Android failure is legit.

[commit-bot: I haz the power, 2017-08-04 01:54:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-04 01:54:39]

Try jobs failed on following builders:
  Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)

[pfeldman, 2017-08-04 17:28:50]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-04 17:28:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-04 17:56:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-04 17:56:29]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2017-08-04 18:41:43]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-08-04 18:41:43]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2989413002/#ps20001
(title: "added default value for target")

[commit-bot: I haz the power, 2017-08-04 18:41:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-04 18:43:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1501872103416660,
"parent_rev": "a1ed0fb76e1d0eca4b9aec1bb657e47efa2bd643", "commit_rev":
"0c52f6ade0f544259f977ace6c290a510502410f"}

[commit-bot: I haz the power, 2017-08-04 18:43:55]

Description was changed from

==========
Take non-default browser target location into account when attaching to it.

BUG=chromium:666865
==========

to

==========
Take non-default browser target location into account when attaching to it.

BUG=chromium:666865

Review-Url: https://codereview.chromium.org/2989413002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-08-04 18:43:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...