Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py

Issue 2989413002: Take non-default browser target location into account when attaching to it. (Closed)
Patch Set: added default value for target Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
diff --git a/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
index 1c8ed1aa33644403055d371ccedaa067429e7b50..9090b353a20430fe0f1b0a865799653e0dabfab3 100644
--- a/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
+++ b/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
@@ -134,6 +134,7 @@ class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
self._browser_directory = browser_directory
self._port = None
+ self._browser_target = None
self._tmp_minidump_dir = tempfile.mkdtemp()
if self.is_logging_enabled:
self._log_file_path = os.path.join(tempfile.mkdtemp(), 'chrome.log')
@@ -234,9 +235,12 @@ class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
try:
if os.stat(port_file).st_size > 0:
with open(port_file) as f:
- port_string = f.read()
- self._port = int(port_string)
+ port_target = f.read().split('\n')
+ self._port = int(port_target[0])
+ if len(port_target) > 1 and port_target[1]:
+ self._browser_target = port_target[1]
logging.info('Discovered ephemeral port %s', self._port)
+ logging.info('Browser target: %s', self._browser_target)
got_port = True
except Exception:
# Both stat and open can throw exceptions.
@@ -301,6 +305,7 @@ class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
'Chrome log file will be saved in %s\n' % self.log_file_path)
env['CHROME_LOG_FILE'] = self.log_file_path
logging.info('Starting Chrome %s', args)
+
if not self.browser_options.show_stdout:
self._tmp_output_file = tempfile.NamedTemporaryFile('w', 0)
self._proc = subprocess.Popen(

Powered by Google App Engine
This is Rietveld 408576698