Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/system_info_backend.py

Issue 2989413002: Take non-default browser target location into account when attaching to it. (Closed)
Patch Set: added default value for target Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/backends/chrome_inspector/system_info_backend.py
diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/system_info_backend.py b/telemetry/telemetry/internal/backends/chrome_inspector/system_info_backend.py
index 1a3c2d9c813baa9f2d133c10185ee2fea3207b19..6df3cdfdf4732fd4fdc873afb44c22bb86afbaa0 100644
--- a/telemetry/telemetry/internal/backends/chrome_inspector/system_info_backend.py
+++ b/telemetry/telemetry/internal/backends/chrome_inspector/system_info_backend.py
@@ -8,15 +8,14 @@ from py_utils import camel_case
class SystemInfoBackend(object):
- def __init__(self, devtools_port):
- self._port = devtools_port
+ def __init__(self, browser_target_ws):
+ self._browser_target_ws = browser_target_ws
def GetSystemInfo(self, timeout=10):
req = {'method': 'SystemInfo.getInfo'}
websocket = inspector_websocket.InspectorWebsocket()
try:
- websocket.Connect('ws://127.0.0.1:%i/devtools/browser' % self._port,
- timeout)
+ websocket.Connect(self._browser_target_ws, timeout)
res = websocket.SyncRequest(req, timeout)
finally:
websocket.Disconnect()
« no previous file with comments | « telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698