Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Issue 298883006: Rename NOTIFICATION_EXTENSION_INSTALLED to (Closed)

Created:
6 years, 7 months ago by limasdf
Modified:
6 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, tzik, tfarina, dougw+watch_chromium.org, donnd+watch_chromium.org, nhiroki, dominich, samarth+watch_chromium.org, jfweitz+watch_chromium.org, David Black, Jered, oshima+watch_chromium.org, kmadhusu+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Rename NOTIFICATION_EXTENSION_INSTALLED to NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED Since ExtensionRegistry::AddObserver replaces it. This CL is the result of below script, and 'git cl format'. find -regex '.*/.*\.\(mm\|cc\|h\)$' | xargs sed -i s/NOTIFICATION_EXTENSION_INSTALLED/NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED/g BUG=376293 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272440

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -59 lines) Patch
M apps/app_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/shell/browser/shell_extension_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_launcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/apps/ephemeral_app_service.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/apps/shortcut_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chrome_notification_types.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_api.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/storage/managed_value_store_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/convert_web_app_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/error_console/error_console.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_notification_observer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_test_notification_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/state_store.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_startup_installer_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/search/hotword_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
limasdf
This CL is 100% mechanical change. please take a look @kalman = extension @sky = ...
6 years, 7 months ago (2014-05-22 13:02:23 UTC) #1
not at google - send to devlin
lgtm for the record, my rename script is: https://github.com/kalman/rc/blob/master/profile#L294 https://codereview.chromium.org/298883006/diff/1/chrome/browser/chrome_notification_types.h File chrome/browser/chrome_notification_types.h (right): https://codereview.chromium.org/298883006/diff/1/chrome/browser/chrome_notification_types.h#newcode422 chrome/browser/chrome_notification_types.h:422: ...
6 years, 7 months ago (2014-05-22 14:53:55 UTC) #2
sky
LGTM
6 years, 7 months ago (2014-05-22 15:12:41 UTC) #3
limasdf
https://codereview.chromium.org/298883006/diff/1/chrome/browser/chrome_notification_types.h File chrome/browser/chrome_notification_types.h (right): https://codereview.chromium.org/298883006/diff/1/chrome/browser/chrome_notification_types.h#newcode422 chrome/browser/chrome_notification_types.h:422: // The details are an InstalledExtensionInfo, and the source ...
6 years, 7 months ago (2014-05-22 20:48:15 UTC) #4
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 7 months ago (2014-05-22 20:48:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/298883006/20001
6 years, 7 months ago (2014-05-22 20:49:55 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 00:46:22 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 07:56:40 UTC) #8
Message was sent while issue was closed.
Change committed as 272440

Powered by Google App Engine
This is Rietveld 408576698