chrome/browser/performance_monitor/performance_monitor.cc - Issue 298883006: Rename NOTIFICATION_EXTENSION_INSTALLED to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/performance_monitor/performance_monitor.cc

Issue 298883006: Rename NOTIFICATION_EXTENSION_INSTALLED to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/performance_monitor/performance_monitor.cc

diff --git a/chrome/browser/performance_monitor/performance_monitor.cc b/chrome/browser/performance_monitor/performance_monitor.cc

index 889339c8602a221ccc33ee230d5c9c57bba72b92..359cabcdedbba7d873dc7f2b8aa15fc566b502d9 100644

--- a/chrome/browser/performance_monitor/performance_monitor.cc

+++ b/chrome/browser/performance_monitor/performance_monitor.cc

@@ -229,8 +229,9 @@ void PerformanceMonitor::RegisterForNotifications() {

DCHECK(database_logging_enabled_);

// Extensions

- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_INSTALLED,

- content::NotificationService::AllSources());

+ registrar_.Add(this,

+ chrome::NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED,

+ content::NotificationService::AllSources());

registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_ENABLED,

content::NotificationService::AllSources());

registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED,

@@ -554,7 +555,7 @@ void PerformanceMonitor::Observe(int type,

DCHECK(database_logging_enabled_);

switch (type) {

- case chrome::NOTIFICATION_EXTENSION_INSTALLED: {

+ case chrome::NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED: {

AddExtensionEvent(

EVENT_EXTENSION_INSTALL,

content::Details<const extensions::InstalledExtensionInfo>(details)->