chrome/browser/apps/ephemeral_app_launcher.cc - Issue 298883006: Rename NOTIFICATION_EXTENSION_INSTALLED to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_launcher.cc

Issue 298883006: Rename NOTIFICATION_EXTENSION_INSTALLED to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/apps/ephemeral_app_launcher.cc

diff --git a/chrome/browser/apps/ephemeral_app_launcher.cc b/chrome/browser/apps/ephemeral_app_launcher.cc

index 0324d68431aff2834738cacb8de8753c3a0c0be7..9aa495fb9d606ceaf4174420486be5f8e5b92931 100644

--- a/chrome/browser/apps/ephemeral_app_launcher.cc

+++ b/chrome/browser/apps/ephemeral_app_launcher.cc

@@ -242,7 +242,8 @@ void EphemeralAppLauncher::CompleteInstall(const std::string& error) {

WebstoreStandaloneInstaller::CompleteInstall(error);

// If the installation succeeds, we reach this point as a result of

- // chrome::NOTIFICATION_EXTENSION_INSTALLED, but this is broadcasted before

+ // chrome::NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED, but this is

+ // broadcasted before

// ExtensionService has added the extension to its list of installed

// extensions and is too early to launch the app. Instead, we will launch at

// EphemeralAppLauncher::OnExtensionLoaded().

« no previous file with comments | « chrome/browser/apps/app_browsertest.cc ('k') | chrome/browser/apps/ephemeral_app_service.cc » ('j') | no next file with comments »