Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: chrome/browser/apps/app_browsertest.cc

Issue 298883006: Rename NOTIFICATION_EXTENSION_INSTALLED to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/shell/browser/shell_extension_system.cc ('k') | chrome/browser/apps/ephemeral_app_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/app_browsertest.cc
diff --git a/chrome/browser/apps/app_browsertest.cc b/chrome/browser/apps/app_browsertest.cc
index 0bf5f3ac2313a34267f58355769ae93d44657c38..6576a0a122f718d9d2c71cfa5d60f44746cbd838 100644
--- a/chrome/browser/apps/app_browsertest.cc
+++ b/chrome/browser/apps/app_browsertest.cc
@@ -949,13 +949,14 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, ReloadRelaunches) {
namespace {
-// Simple observer to check for NOTIFICATION_EXTENSION_INSTALLED events to
+// Simple observer to check for NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED
+// events to
// ensure installation does or does not occur in certain scenarios.
class CheckExtensionInstalledObserver : public content::NotificationObserver {
public:
CheckExtensionInstalledObserver() : seen_(false) {
registrar_.Add(this,
- chrome::NOTIFICATION_EXTENSION_INSTALLED,
+ chrome::NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED,
content::NotificationService::AllSources());
}
@@ -1017,7 +1018,7 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
// should not cause it to be re-installed. Instead, we wait for the OnLaunched
// in a different observer (which would timeout if not the app was not
// previously installed properly) and then check this observer to make sure it
- // never saw the NOTIFICATION_EXTENSION_INSTALLED event.
+ // never saw the NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED event.
CheckExtensionInstalledObserver should_not_install;
const Extension* extension = LoadExtensionAsComponent(
test_data_dir_.AppendASCII("platform_apps").AppendASCII("component"));
« no previous file with comments | « apps/shell/browser/shell_extension_system.cc ('k') | chrome/browser/apps/ephemeral_app_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698