Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2988133002: isolate: manage lifetime of checker and uploader in main. (Closed)

Created:
3 years, 4 months ago by mcgreevy
Modified:
3 years, 4 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

isolate: manage lifetime of checker and uploader in main. It makes sense for the uploader and checker to be Closed in the same block of code that they are created in. This will also make it possible to share Checker and Uploaders between TarringArchivers. BUG=692940 Review-Url: https://codereview.chromium.org/2988133002 Committed: https://github.com/luci/luci-go/commit/300d5a6b74053bed93529c62119d09516c14b447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M client/cmd/isolate/exp_archive.go View 1 chunk +11 lines, -0 lines 0 comments Download
M client/cmd/isolate/upload_tracker.go View 1 chunk +0 lines, -10 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
mcgreevy
3 years, 4 months ago (2017-07-31 05:59:58 UTC) #2
mithro
lgtm LGTM.
3 years, 4 months ago (2017-07-31 06:26:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2988133002/1
3 years, 4 months ago (2017-08-01 04:34:47 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-01 04:42:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/300d5a6b74053bed93529c62119d09516c14b447

Powered by Google App Engine
This is Rietveld 408576698