Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2991083002: isolate: Move partitioning code out of exparchive main. (Closed)

Created:
3 years, 4 months ago by mcgreevy
Modified:
3 years, 4 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

isolate: Move partitioning code out of exparchive main. This is mostly just moving code, but the new String method for partitionedDeps produces slightly different output to the old code which was in expArchiveRun.main. BUG=692940 Review-Url: https://codereview.chromium.org/2991083002 Committed: https://github.com/luci/luci-go/commit/7981ab04f53fb3eb949c32f8eafbc077c15d66d5

Patch Set 1 #

Patch Set 2 : refer to isolate rather than isolated path when logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+494 lines, -155 lines) Patch
M client/cmd/isolate/checker.go View 6 chunks +17 lines, -10 lines 0 comments Download
M client/cmd/isolate/exp_archive.go View 3 chunks +2 lines, -124 lines 0 comments Download
A client/cmd/isolate/tarring_archiver.go View 1 1 chunk +160 lines, -0 lines 0 comments Download
M client/cmd/isolate/upload_tracker.go View 6 chunks +45 lines, -8 lines 0 comments Download
A client/cmd/isolate/upload_tracker_test.go View 1 chunk +248 lines, -0 lines 0 comments Download
M client/cmd/isolate/uploader.go View 7 chunks +22 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mcgreevy
3 years, 4 months ago (2017-07-31 05:59:30 UTC) #2
mithro
On 2017/07/31 05:59:30, mcgreevy wrote: It's hard to see the change in the string because ...
3 years, 4 months ago (2017-07-31 06:28:54 UTC) #3
mcgreevy
On 2017/07/31 06:28:54, mithro wrote: > On 2017/07/31 05:59:30, mcgreevy wrote: > > It's hard ...
3 years, 4 months ago (2017-07-31 06:41:00 UTC) #4
mithro
On 2017/07/31 06:41:00, mcgreevy wrote: > On 2017/07/31 06:28:54, mithro wrote: > > On 2017/07/31 ...
3 years, 4 months ago (2017-07-31 06:57:43 UTC) #5
mcgreevy
On 2017/07/31 06:57:43, mithro wrote: > On 2017/07/31 06:41:00, mcgreevy wrote: > > On 2017/07/31 ...
3 years, 4 months ago (2017-08-01 03:33:23 UTC) #6
mithro
Great LGTM!
3 years, 4 months ago (2017-08-01 03:48:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991083002/20001
3 years, 4 months ago (2017-08-01 03:54:26 UTC) #9
commit-bot: I haz the power
3 years, 4 months ago (2017-08-01 04:02:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/7981ab04f53fb3eb949c32f8eafbc077c15d66d5

Powered by Google App Engine
This is Rietveld 408576698