isolate: Move partitioning code out of exparchive main.

isolate: Move partitioning code out of exparchive main.

This is mostly just moving code, but the new String method for partitionedDeps
produces slightly different output to the old code which was in
expArchiveRun.main.

BUG=692940
Review-Url: https://codereview.chromium.org/2991083002
Committed: https://github.com/luci/luci-go/commit/7981ab04f53fb3eb949c32f8eafbc077c15d66d5

[mcgreevy, 2017-07-31 05:59:28]

mcgreevy@chromium.org changed reviewers:
+ tansell@chromium.org

[mithro, 2017-07-31 06:28:54]

On 2017/07/31 05:59:30, mcgreevy wrote:

It's hard to see the change in the string because of the move. Can you explain
it?

[mcgreevy, 2017-07-31 06:41:00]

On 2017/07/31 06:28:54, mithro wrote:
> On 2017/07/31 05:59:30, mcgreevy wrote:
> 
> It's hard to see the change in the string because of the move. Can you explain
> it?

Old exp_archive.go lines 208..212
became:
new tarring_archiver.go lines 55 and 100..105

[mithro, 2017-07-31 06:57:43]

On 2017/07/31 06:41:00, mcgreevy wrote:
> On 2017/07/31 06:28:54, mithro wrote:
> > On 2017/07/31 05:59:30, mcgreevy wrote:
> > 
> > It's hard to see the change in the string because of the move. Can you
explain
> > it?
> 
> Old exp_archive.go lines 208..212
> became:
> new tarring_archiver.go lines 55 and 100..105

Yes, I understood what moved. I don't understand how the code changed in the
move...

[mcgreevy, 2017-08-01 03:33:23]

On 2017/07/31 06:57:43, mithro wrote:
> On 2017/07/31 06:41:00, mcgreevy wrote:
> > On 2017/07/31 06:28:54, mithro wrote:
> > > On 2017/07/31 05:59:30, mcgreevy wrote:
> > > 
> > > It's hard to see the change in the string because of the move. Can you
> explain
> > > it?
> > 
> > Old exp_archive.go lines 208..212
> > became:
> > new tarring_archiver.go lines 55 and 100..105
> 
> Yes, I understood what moved. I don't understand how the code changed in the
> move...

New output:

13:23:22.730089 Isolate /path/to/hello_world.isolate referenced 3 deps
13:23:22.730283 Isolate /path/to/hello_world.isolate expanded to the following
items to be isolated:
  0 symlinks
  0 individual files (total size: 0 B)
  5 files in archives (total size 695 B)
13:23:22.730310 	1 TAR archives to be isolated
13:23:22.730533 Created tar archive "1951fd9556edeb7c972179ef829792eadcaa3204"
(6.7 kB)
13:23:22.730549 	contains 5 files (total 695 B)
e714242f923c5c46e193b6f190738a034f6c5a12	exparchive



Old output:

13:20:31.157285 Isolate referenced 3 deps
13:20:31.157686 Isolate expanded to 5 files (total size 695 B) and 0 symlinks
13:20:31.157702 	0 files (0 B) to be isolated individually
13:20:31.157709 	5 files (695 B) to be isolated in archives
13:20:31.157722 	1 TAR archives to be isolated
13:20:31.157927 Created tar archive "1951fd9556edeb7c972179ef829792eadcaa3204"
(6.7 kB)
13:20:31.157939 	contains 5 files (total 695 B)
e714242f923c5c46e193b6f190738a034f6c5a12	exparchive


(note: in case you're wondering, "exparchive" appears in the above output
because the isolated file is called "exparchive.isolated").

[mithro, 2017-08-01 03:48:52]

Great LGTM!

[mcgreevy, 2017-08-01 03:54:24]

The CQ bit was checked by mcgreevy@chromium.org

[commit-bot: I haz the power, 2017-08-01 03:54:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-01 04:02:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1501559664107450,
"parent_rev": "b6f37562e3b7780198095124623d6e40fce9971d", "commit_rev":
"7981ab04f53fb3eb949c32f8eafbc077c15d66d5"}

[commit-bot: I haz the power, 2017-08-01 04:02:13]

Description was changed from

==========
isolate: Move partitioning code out of exparchive main.

This is mostly just moving code, but the new String method for partitionedDeps
produces slightly different output to the old code which was in
expArchiveRun.main.

BUG=692940
==========

to

==========
isolate: Move partitioning code out of exparchive main.

This is mostly just moving code, but the new String method for partitionedDeps
produces slightly different output to the old code which was in
expArchiveRun.main.

BUG=692940

Review-Url: https://codereview.chromium.org/2991083002
Committed:
https://github.com/luci/luci-go/commit/7981ab04f53fb3eb949c32f8eafbc077c15d66d5
==========

[commit-bot: I haz the power, 2017-08-01 04:02:14]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/7981ab04f53fb3eb949c32f8eafbc077c15d66d5