Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: client/cmd/isolate/upload_tracker.go

Issue 2988133002: isolate: manage lifetime of checker and uploader in main. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/cmd/isolate/exp_archive.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/cmd/isolate/upload_tracker.go
diff --git a/client/cmd/isolate/upload_tracker.go b/client/cmd/isolate/upload_tracker.go
index 8ff7fe4ed386e9ce9383ccb55c9101bc9e789e6d..44f00c89fd8d9397e85f9fdb9bfd7ee673918dff 100644
--- a/client/cmd/isolate/upload_tracker.go
+++ b/client/cmd/isolate/upload_tracker.go
@@ -197,16 +197,6 @@ func (ut *UploadTracker) Finalize(isolatedPath string) (IsolatedSummary, error)
})
})
- // Make sure that all pending items have been checked.
- if err := ut.checker.Close(); err != nil {
- return IsolatedSummary{}, err
- }
-
- // Make sure that all the uploads have completed successfully.
- if err := ut.uploader.Close(); err != nil {
- return IsolatedSummary{}, err
- }
-
// Write the isolated file...
if err := isolFile.writeJSONFile(ut.lOS); err != nil {
return IsolatedSummary{}, err
« no previous file with comments | « client/cmd/isolate/exp_archive.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698