Refactor and move ash independent nested accelerator code to ui/wm/core

Refactor and move ash independent accelerator handling code in nested loop to ui/wm/core

I also renamed classes to NestedAcceleratorXxx. I felt this is a bit more clearer than NestedDispatcher, especially in ui/wm/core. Please let me know if you disagree or have better suggestion. I'm happy to rename them.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272740

R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272995

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273114

[Ben Goodger (Google), 2014-05-23 20:24:07]

lgtm

[oshima, 2014-05-24 09:20:34]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-05-24 09:21:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/298703007/190001

[commit-bot: I haz the power, 2014-05-24 13:23:07]

Change committed as 272740

[mmenke, 2014-05-25 13:34:45]

On 2014/05/24 13:23:07, I haz the power (commit-bot) wrote:
> Change committed as 272740

Going to revert this.  This seems to have incompatabilities with
https://codereview.chromium.org/298703007 on Windows (Trybots used an earlier
revision).  If I'm wrong about that, I'll reland it.

[oshima, 2014-05-27 16:14:01]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-05-27 16:14:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/298703007/210001

[commit-bot: I haz the power, 2014-05-27 17:32:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[oshima, 2014-05-27 17:47:01]

Committed patchset #4 manually as r272995 (presubmit successful).

[msw, 2014-05-27 19:01:44]

A revert of this CL has been created in
https://codereview.chromium.org/301743002/ by msw@chromium.org.

The reason for reverting is: caused test failures:
http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/19236

NestedAcceleratorTest.AcceleratorsHandled (run #1):
[ RUN      ] NestedAcceleratorTest.AcceleratorsHandled
Backtrace:
	ui::PlatformEventSource::OverrideDispatcher [0x0028B66D+253]
	wm::test::NestedAcceleratorTest_AcceleratorsHandled_Test::TestBody
[0x00455D37+215]
	testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::Test,void>
[0x004D5829+329]
	testing::Test::Run [0x004EFF9E+174]
	testing::TestInfo::Run [0x004F023D+221]
	testing::TestCase::Run [0x004F00DF+239]
	testing::internal::UnitTestImpl::RunAllTests [0x004F0696+726]
	testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl,bool>
[0x004D5D21+337]
	testing::UnitTest::Run [0x004F0393+211]
	RUN_ALL_TESTS [0x004A0EDF+15]
	base::TestSuite::Run [0x004A1129+233]
	base::internal::RunnableAdapter\u003Cint (__thiscall
base::TestSuite::*)(void)>::Run [0x004150EB+27]
	base::internal::InvokeHelper\u003C0,int,base::internal::RunnableAdapter\u003Cint
(__thiscall base::TestSuite::*)(void)>,void __cdecl(WMTestSuite *)>::MakeItSo
[0x00414FFA+26]
	base::internal::Invoker\u003C1,base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cint
(__thiscall base::TestSuite::*)(void)>,int __cdecl(base::TestSuite *),void
__cdecl(base::internal::UnretainedWrapper\u003CWMTestSuite>)>,int
__cdecl(base::TestSuite *)>::Ru [0x0041506A+74]
	base::Callback\u003Cint __cdecl(void)>::Run [0x0049A03F+47]
	base::`anonymous namespace'::LaunchUnitTestsInternal [0x004990C9+921]
	base::LaunchUnitTests [0x00498D15+37]
	main [0x0041681C+140]
	__tmainCRTStartup [0x00647D39+409]
(f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:626)
	mainCRTStartup [0x00647E7D+13] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466)
	BaseThreadInitThunk [0x76568624+14]
	RtlInitializeExceptionChain [0x773CAC69+133]
	RtlInitializeExceptionChain [0x773CAC3C+88]


NestedAcceleratorTest.AssociatedWindowAboveLockScreen (run #1):
[ RUN      ] NestedAcceleratorTest.AssociatedWindowAboveLockScreen
Backtrace:
	ui::PlatformEventSource::OverrideDispatcher [0x0286B66D+253]
	wm::test::NestedAcceleratorTest_AssociatedWindowAboveLockScreen_Test::TestBody
[0x004563B5+517]
	testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::Test,void>
[0x004D5829+329]
	testing::Test::Run [0x004EFF9E+174]
	testing::TestInfo::Run [0x004F023D+221]
	testing::TestCase::Run [0x004F00DF+239]
	testing::internal::UnitTestImpl::RunAllTests [0x004F0696+726]
	testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl,bool>
[0x004D5D21+337]
	testing::UnitTest::Run [0x004F0393+211]
	RUN_ALL_TESTS [0x004A0EDF+15]
	base::TestSuite::Run [0x004A1129+233]
	base::internal::RunnableAdapter\u003Cint (__thiscall
base::TestSuite::*)(void)>::Run [0x004150EB+27]
	base::internal::InvokeHelper\u003C0,int,base::internal::RunnableAdapter\u003Cint
(__thiscall base::TestSuite::*)(void)>,void __cdecl(WMTestSuite *)>::MakeItSo
[0x00414FFA+26]
	base::internal::Invoker\u003C1,base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cint
(__thiscall base::TestSuite::*)(void)>,int __cdecl(base::TestSuite *),void
__cdecl(base::internal::UnretainedWrapper\u003CWMTestSuite>)>,int
__cdecl(base::TestSuite *)>::Ru [0x0041506A+74]
	base::Callback\u003Cint __cdecl(void)>::Run [0x0049A03F+47]
	base::`anonymous namespace'::LaunchUnitTestsInternal [0x004990C9+921]
	base::LaunchUnitTests [0x00498D15+37]
	main [0x0041681C+140]
	__tmainCRTStartup [0x00647D39+409]
(f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:626)
	mainCRTStartup [0x00647E7D+13] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466)
	BaseThreadInitThunk [0x76568624+14]
	RtlInitializeExceptionChain [0x773CAC69+133]
	RtlInitializeExceptionChain [0x773CAC3C+88]
.

[oshima, 2014-05-27 19:38:42]

Hmm, looks like CQ does not run wm_unittests on windows ... Thank you for taking
care of it.

On 2014/05/27 19:01:44, msw wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/301743002/ by mailto:msw@chromium.org.
> 
> The reason for reverting is: caused test failures:
> http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/19236
> 
> NestedAcceleratorTest.AcceleratorsHandled (run #1):
> [ RUN      ] NestedAcceleratorTest.AcceleratorsHandled
> Backtrace:
> 	ui::PlatformEventSource::OverrideDispatcher [0x0028B66D+253]
> 	wm::test::NestedAcceleratorTest_AcceleratorsHandled_Test::TestBody
> [0x00455D37+215]
>
	testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::Test,void>
> [0x004D5829+329]
> 	testing::Test::Run [0x004EFF9E+174]
> 	testing::TestInfo::Run [0x004F023D+221]
> 	testing::TestCase::Run [0x004F00DF+239]
> 	testing::internal::UnitTestImpl::RunAllTests [0x004F0696+726]
>
	testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl,bool>
> [0x004D5D21+337]
> 	testing::UnitTest::Run [0x004F0393+211]
> 	RUN_ALL_TESTS [0x004A0EDF+15]
> 	base::TestSuite::Run [0x004A1129+233]
> 	base::internal::RunnableAdapter\u003Cint (__thiscall
> base::TestSuite::*)(void)>::Run [0x004150EB+27]
>
	base::internal::InvokeHelper\u003C0,int,base::internal::RunnableAdapter\u003Cint
> (__thiscall base::TestSuite::*)(void)>,void __cdecl(WMTestSuite *)>::MakeItSo
> [0x00414FFA+26]
>
	base::internal::Invoker\u003C1,base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cint
> (__thiscall base::TestSuite::*)(void)>,int __cdecl(base::TestSuite *),void
> __cdecl(base::internal::UnretainedWrapper\u003CWMTestSuite>)>,int
> __cdecl(base::TestSuite *)>::Ru [0x0041506A+74]
> 	base::Callback\u003Cint __cdecl(void)>::Run [0x0049A03F+47]
> 	base::`anonymous namespace'::LaunchUnitTestsInternal [0x004990C9+921]
> 	base::LaunchUnitTests [0x00498D15+37]
> 	main [0x0041681C+140]
> 	__tmainCRTStartup [0x00647D39+409]
> (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:626)
> 	mainCRTStartup [0x00647E7D+13]
(f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466)
> 	BaseThreadInitThunk [0x76568624+14]
> 	RtlInitializeExceptionChain [0x773CAC69+133]
> 	RtlInitializeExceptionChain [0x773CAC3C+88]
> 
> 
> NestedAcceleratorTest.AssociatedWindowAboveLockScreen (run #1):
> [ RUN      ] NestedAcceleratorTest.AssociatedWindowAboveLockScreen
> Backtrace:
> 	ui::PlatformEventSource::OverrideDispatcher [0x0286B66D+253]
>
	wm::test::NestedAcceleratorTest_AssociatedWindowAboveLockScreen_Test::TestBody
> [0x004563B5+517]
>
	testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::Test,void>
> [0x004D5829+329]
> 	testing::Test::Run [0x004EFF9E+174]
> 	testing::TestInfo::Run [0x004F023D+221]
> 	testing::TestCase::Run [0x004F00DF+239]
> 	testing::internal::UnitTestImpl::RunAllTests [0x004F0696+726]
>
	testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl,bool>
> [0x004D5D21+337]
> 	testing::UnitTest::Run [0x004F0393+211]
> 	RUN_ALL_TESTS [0x004A0EDF+15]
> 	base::TestSuite::Run [0x004A1129+233]
> 	base::internal::RunnableAdapter\u003Cint (__thiscall
> base::TestSuite::*)(void)>::Run [0x004150EB+27]
>
	base::internal::InvokeHelper\u003C0,int,base::internal::RunnableAdapter\u003Cint
> (__thiscall base::TestSuite::*)(void)>,void __cdecl(WMTestSuite *)>::MakeItSo
> [0x00414FFA+26]
>
	base::internal::Invoker\u003C1,base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cint
> (__thiscall base::TestSuite::*)(void)>,int __cdecl(base::TestSuite *),void
> __cdecl(base::internal::UnretainedWrapper\u003CWMTestSuite>)>,int
> __cdecl(base::TestSuite *)>::Ru [0x0041506A+74]
> 	base::Callback\u003Cint __cdecl(void)>::Run [0x0049A03F+47]
> 	base::`anonymous namespace'::LaunchUnitTestsInternal [0x004990C9+921]
> 	base::LaunchUnitTests [0x00498D15+37]
> 	main [0x0041681C+140]
> 	__tmainCRTStartup [0x00647D39+409]
> (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:626)
> 	mainCRTStartup [0x00647E7D+13]
(f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466)
> 	BaseThreadInitThunk [0x76568624+14]
> 	RtlInitializeExceptionChain [0x773CAC69+133]
> 	RtlInitializeExceptionChain [0x773CAC3C+88]
> .

[oshima, 2014-05-27 22:49:51]

The test doesn't pass on Windows a
because Window does not have PlatformEventSource, and it was originally excluded
in ash.gyp.

Sadrul is planning to implement PES on Windows, so I simply skipped the test if
PES is NULL in the test.

[oshima, 2014-05-27 22:49:56]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-05-27 22:51:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/298703007/240001

[commit-bot: I haz the power, 2014-05-28 02:41:04]

Change committed as 273114