Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Side by Side Diff: ui/wm/core/nested_accelerator_controller_unittest.cc

Issue 298703007: Refactor and move ash independent nested accelerator code to ui/wm/core (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: skip test if platform does not support PES Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ui/wm/core/nested_accelerator_controller.cc ('k') | ui/wm/core/nested_accelerator_delegate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "ui/wm/core/nested_accelerator_controller.h"
6
7 #include "base/bind.h"
8 #include "base/event_types.h"
9 #include "base/message_loop/message_loop.h"
10 #include "ui/aura/test/aura_test_base.h"
11 #include "ui/aura/test/test_windows.h"
12 #include "ui/aura/window.h"
13 #include "ui/aura/window_event_dispatcher.h"
14 #include "ui/base/accelerators/accelerator.h"
15 #include "ui/base/accelerators/accelerator.h"
16 #include "ui/base/accelerators/accelerator_manager.h"
17 #include "ui/events/event_constants.h"
18 #include "ui/events/event_utils.h"
19 #include "ui/events/platform/platform_event_dispatcher.h"
20 #include "ui/events/platform/platform_event_source.h"
21 #include "ui/events/platform/scoped_event_dispatcher.h"
22 #include "ui/wm/core/nested_accelerator_delegate.h"
23 #include "ui/wm/public/dispatcher_client.h"
24
25 #if defined(USE_X11)
26 #include <X11/Xlib.h>
27 #include "ui/events/test/events_test_utils_x11.h"
28 #endif // USE_X11
29
30 namespace wm {
31 namespace test {
32
33 namespace {
34
35 class MockDispatcher : public ui::PlatformEventDispatcher {
36 public:
37 MockDispatcher() : num_key_events_dispatched_(0) {}
38
39 int num_key_events_dispatched() { return num_key_events_dispatched_; }
40
41 private:
42 // ui::PlatformEventDispatcher:
43 virtual bool CanDispatchEvent(const ui::PlatformEvent& event) OVERRIDE {
44 return true;
45 }
46 virtual uint32_t DispatchEvent(const ui::PlatformEvent& event) OVERRIDE {
47 if (ui::EventTypeFromNative(event) == ui::ET_KEY_RELEASED)
48 num_key_events_dispatched_++;
49 return ui::POST_DISPATCH_NONE;
50 }
51
52 int num_key_events_dispatched_;
53
54 DISALLOW_COPY_AND_ASSIGN(MockDispatcher);
55 };
56
57 class TestTarget : public ui::AcceleratorTarget {
58 public:
59 TestTarget() : accelerator_pressed_count_(0) {}
60 virtual ~TestTarget() {}
61
62 int accelerator_pressed_count() const { return accelerator_pressed_count_; }
63
64 // Overridden from ui::AcceleratorTarget:
65 virtual bool AcceleratorPressed(const ui::Accelerator& accelerator) OVERRIDE {
66 accelerator_pressed_count_++;
67 return true;
68 }
69 virtual bool CanHandleAccelerators() const OVERRIDE { return true; }
70
71 private:
72 int accelerator_pressed_count_;
73
74 DISALLOW_COPY_AND_ASSIGN(TestTarget);
75 };
76
77 void DispatchKeyReleaseA(aura::Window* root_window) {
78 // Sending both keydown and keyup is necessary here because the accelerator
79 // manager only checks a keyup event following a keydown event. See
80 // ShouldHandle() in ui/base/accelerators/accelerator_manager.cc for details.
81 #if defined(OS_WIN)
82 MSG native_event_down = {NULL, WM_KEYDOWN, ui::VKEY_A, 0};
83 aura::WindowTreeHost* host = root_window->GetHost();
84 host->PostNativeEvent(native_event_down);
85 MSG native_event_up = {NULL, WM_KEYUP, ui::VKEY_A, 0};
86 host->PostNativeEvent(native_event_up);
87 #elif defined(USE_X11)
88 ui::ScopedXI2Event native_event;
89 native_event.InitKeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_A, 0);
90 aura::WindowTreeHost* host = root_window->GetHost();
91 host->PostNativeEvent(native_event);
92 native_event.InitKeyEvent(ui::ET_KEY_RELEASED, ui::VKEY_A, 0);
93 host->PostNativeEvent(native_event);
94 #endif
95 // Make sure the inner message-loop terminates after dispatching the events.
96 base::MessageLoop::current()->PostTask(
97 FROM_HERE, base::MessageLoop::current()->QuitClosure());
98 }
99
100 class MockNestedAcceleratorDelegate : public NestedAcceleratorDelegate {
101 public:
102 MockNestedAcceleratorDelegate()
103 : accelerator_manager_(new ui::AcceleratorManager) {}
104 virtual ~MockNestedAcceleratorDelegate() {}
105
106 // NestedAcceleratorDelegate:
107 virtual bool ShouldProcessEventNow(const ui::KeyEvent& key_event) OVERRIDE {
108 return true;
109 }
110 virtual bool ProcessEvent(const ui::KeyEvent& key_event) OVERRIDE {
111 const int kModifierMask =
112 (ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN | ui::EF_ALT_DOWN);
113 ui::Accelerator accelerator(key_event.key_code(),
114 key_event.flags() & kModifierMask);
115 if (key_event.type() == ui::ET_KEY_RELEASED)
116 accelerator.set_type(ui::ET_KEY_RELEASED);
117 return accelerator_manager_->Process(accelerator);
118 }
119
120 void Register(const ui::Accelerator& accelerator,
121 ui::AcceleratorTarget* target) {
122 accelerator_manager_->Register(
123 accelerator, ui::AcceleratorManager::kNormalPriority, target);
124 }
125
126 private:
127 scoped_ptr<ui::AcceleratorManager> accelerator_manager_;
128
129 DISALLOW_COPY_AND_ASSIGN(MockNestedAcceleratorDelegate);
130 };
131
132 class NestedAcceleratorTest : public aura::test::AuraTestBase {
133 public:
134 NestedAcceleratorTest() {}
135 virtual ~NestedAcceleratorTest() {}
136
137 virtual void SetUp() OVERRIDE {
138 AuraTestBase::SetUp();
139 delegate_ = new MockNestedAcceleratorDelegate();
140 nested_accelerator_controller_.reset(
141 new NestedAcceleratorController(delegate_));
142 aura::client::SetDispatcherClient(root_window(),
143 nested_accelerator_controller_.get());
144 }
145
146 virtual void TearDown() OVERRIDE {
147 aura::client::SetDispatcherClient(root_window(), NULL);
148 AuraTestBase::TearDown();
149 delegate_ = NULL;
150 nested_accelerator_controller_.reset();
151 }
152
153 MockNestedAcceleratorDelegate* delegate() { return delegate_; }
154
155 private:
156 scoped_ptr<NestedAcceleratorController> nested_accelerator_controller_;
157 MockNestedAcceleratorDelegate* delegate_;
158
159 DISALLOW_COPY_AND_ASSIGN(NestedAcceleratorTest);
160 };
161
162 } // namespace
163
164 // Aura window above lock screen in z order.
165 TEST_F(NestedAcceleratorTest, AssociatedWindowAboveLockScreen) {
166 // TODO(oshima|sadrul): remove when Win implements PES.
167 if (!ui::PlatformEventSource::GetInstance())
168 return;
169 MockDispatcher inner_dispatcher;
170 scoped_ptr<aura::Window> mock_lock_container(
171 CreateNormalWindow(0, root_window(), NULL));
172 aura::test::CreateTestWindowWithId(1, mock_lock_container.get());
173
174 scoped_ptr<aura::Window> associated_window(
175 CreateNormalWindow(2, root_window(), NULL));
176 EXPECT_TRUE(aura::test::WindowIsAbove(associated_window.get(),
177 mock_lock_container.get()));
178
179 DispatchKeyReleaseA(root_window());
180 scoped_ptr<ui::ScopedEventDispatcher> override_dispatcher =
181 ui::PlatformEventSource::GetInstance()->OverrideDispatcher(
182 &inner_dispatcher);
183 aura::client::GetDispatcherClient(root_window())->RunWithDispatcher(NULL);
184 EXPECT_EQ(1, inner_dispatcher.num_key_events_dispatched());
185 }
186
187 // Test that the nested dispatcher handles accelerators.
188 TEST_F(NestedAcceleratorTest, AcceleratorsHandled) {
189 // TODO(oshima|sadrul): remove when Win implements PES.
190 if (!ui::PlatformEventSource::GetInstance())
191 return;
192 MockDispatcher inner_dispatcher;
193 ui::Accelerator accelerator(ui::VKEY_A, ui::EF_NONE);
194 accelerator.set_type(ui::ET_KEY_RELEASED);
195 TestTarget target;
196 delegate()->Register(accelerator, &target);
197
198 DispatchKeyReleaseA(root_window());
199 scoped_ptr<ui::ScopedEventDispatcher> override_dispatcher =
200 ui::PlatformEventSource::GetInstance()->OverrideDispatcher(
201 &inner_dispatcher);
202 aura::client::GetDispatcherClient(root_window())->RunWithDispatcher(NULL);
203 EXPECT_EQ(0, inner_dispatcher.num_key_events_dispatched());
204 EXPECT_EQ(1, target.accelerator_pressed_count());
205 }
206
207 } // namespace test
208 } // namespace wm
OLDNEW
« no previous file with comments | « ui/wm/core/nested_accelerator_controller.cc ('k') | ui/wm/core/nested_accelerator_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698