Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: ash/accelerators/nested_accelerator_delegate.cc

Issue 298703007: Refactor and move ash independent nested accelerator code to ui/wm/core (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: skip test if platform does not support PES Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/accelerators/accelerator_dispatcher.h" 5 #include "ash/accelerators/nested_accelerator_delegate.h"
6 6
7 #include "ash/accelerators/accelerator_controller.h" 7 #include "ash/accelerators/accelerator_controller.h"
8 #include "ash/shell.h" 8 #include "ash/shell.h"
9 #include "ui/aura/window_event_dispatcher.h" 9 #include "ui/aura/window_event_dispatcher.h"
10 #include "ui/base/accelerators/accelerator.h" 10 #include "ui/base/accelerators/accelerator.h"
11 #include "ui/events/event.h" 11 #include "ui/events/event.h"
12 #include "ui/events/event_constants.h" 12 #include "ui/events/event_constants.h"
13 #include "ui/events/event_utils.h" 13 #include "ui/events/event_utils.h"
14 #include "ui/views/controls/menu/menu_controller.h" 14 #include "ui/views/controls/menu/menu_controller.h"
15 15
(...skipping 12 matching lines...) Expand all
28 (key_code >= ui::VKEY_0 && key_code <= ui::VKEY_9) || 28 (key_code >= ui::VKEY_0 && key_code <= ui::VKEY_9) ||
29 (key_code == ui::VKEY_TAB)) { 29 (key_code == ui::VKEY_TAB)) {
30 return true; 30 return true;
31 } 31 }
32 } 32 }
33 return false; 33 return false;
34 } 34 }
35 35
36 } // namespace 36 } // namespace
37 37
38 bool AcceleratorDispatcher::MenuClosedForPossibleAccelerator( 38 NestedAcceleratorDelegate::NestedAcceleratorDelegate() {
39 }
40
41 NestedAcceleratorDelegate::~NestedAcceleratorDelegate() {
42 }
43
44 bool NestedAcceleratorDelegate::ShouldProcessEventNow(
39 const ui::KeyEvent& key_event) { 45 const ui::KeyEvent& key_event) {
40 if (!IsPossibleAcceleratorNotForMenu(key_event)) 46 if (!IsPossibleAcceleratorNotForMenu(key_event))
41 return false; 47 return true;
42 48
43 if (views::MenuController* menu_controller = 49 if (views::MenuController* menu_controller =
44 views::MenuController::GetActiveInstance()) { 50 views::MenuController::GetActiveInstance()) {
45 menu_controller->CancelAll(); 51 menu_controller->CancelAll();
46 return true; 52 return false;
47 } 53 }
48 return false; 54 return true;
49 } 55 }
50 56
51 bool AcceleratorDispatcher::AcceleratorProcessedForKeyEvent( 57 bool NestedAcceleratorDelegate::ProcessEvent(const ui::KeyEvent& key_event) {
52 const ui::KeyEvent& key_event) {
53 ash::AcceleratorController* accelerator_controller = 58 ash::AcceleratorController* accelerator_controller =
54 ash::Shell::GetInstance()->accelerator_controller(); 59 ash::Shell::GetInstance()->accelerator_controller();
55 if (!accelerator_controller) 60 if (!accelerator_controller)
56 return false; 61 return false;
57 const int kModifierMask = 62 const int kModifierMask =
58 (ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN | ui::EF_ALT_DOWN); 63 (ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN | ui::EF_ALT_DOWN);
59 ui::Accelerator accelerator(key_event.key_code(), 64 ui::Accelerator accelerator(key_event.key_code(),
60 key_event.flags() & kModifierMask); 65 key_event.flags() & kModifierMask);
61 if (key_event.type() == ui::ET_KEY_RELEASED) 66 if (key_event.type() == ui::ET_KEY_RELEASED)
62 accelerator.set_type(ui::ET_KEY_RELEASED); 67 accelerator.set_type(ui::ET_KEY_RELEASED);
63 // Fill out context object so AcceleratorController will know what 68 // Fill out context object so AcceleratorController will know what
64 // was the previous accelerator or if the current accelerator is repeated. 69 // was the previous accelerator or if the current accelerator is repeated.
65 Shell::GetInstance()->accelerator_controller()->context()->UpdateContext( 70 Shell::GetInstance()->accelerator_controller()->context()->UpdateContext(
66 accelerator); 71 accelerator);
67 return accelerator_controller->Process(accelerator); 72 return accelerator_controller->Process(accelerator);
68 } 73 }
69 74
70 } // namespace ash 75 } // namespace ash
OLDNEW
« no previous file with comments | « ash/accelerators/nested_accelerator_delegate.h ('k') | ash/accelerators/nested_dispatcher_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698