Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2986423002: tokenserver: Fix some mistakes in proto docs for new token grants feature. (Closed)

Created:
3 years, 4 months ago by Vadim Sh.
Modified:
3 years, 4 months ago
Reviewers:
smut
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

tokenserver: Fix some mistakes in proto docs for new token grants feature. R=smut@google.com BUG=731843 Review-Url: https://codereview.chromium.org/2986423002 Committed: https://github.com/luci/luci-go/commit/5059169d54c9243ad7234ce9174ff604b91857a9

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1192 lines, -1196 lines) Patch
M tokenserver/api/admin/v1/pb.discovery.go View 1 chunk +1188 lines, -1188 lines 0 comments Download
M tokenserver/api/oauth_token_grant.proto View 2 chunks +2 lines, -4 lines 0 comments Download
M tokenserver/api/oauth_token_grant.pb.go View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Vadim Sh.
two line change in a separate commit because proto regeneration CLs are huge in terms ...
3 years, 4 months ago (2017-08-04 05:55:53 UTC) #1
smut
lgtm
3 years, 4 months ago (2017-08-04 23:08:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2986423002/20001
3 years, 4 months ago (2017-08-04 23:39:35 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-04 23:51:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/5059169d54c9243ad7234ce9174ff604b91857a9

Powered by Google App Engine
This is Rietveld 408576698