Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tokenserver/api/oauth_token_grant.proto

Issue 2986423002: tokenserver: Fix some mistakes in proto docs for new token grants feature. (Closed)
Patch Set: rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tokenserver/api/admin/v1/pb.discovery.go ('k') | tokenserver/api/oauth_token_grant.pb.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tokenserver/api/oauth_token_grant.proto
diff --git a/tokenserver/api/oauth_token_grant.proto b/tokenserver/api/oauth_token_grant.proto
index f98052fe209431ef10c72acd4d3a4932fea2a609..b7cdefbfab78524057b59fd75fb582a69c4b524d 100644
--- a/tokenserver/api/oauth_token_grant.proto
+++ b/tokenserver/api/oauth_token_grant.proto
@@ -22,9 +22,7 @@ message OAuthTokenGrantBody {
// TODO(vadimsh): It may later be used for revocation purposes.
int64 token_id = 1;
- // Service account identity the end user wants to act as.
- //
- // A string of the form "user:<email>".
+ // Service account email the end user wants to act as.
string service_account = 2;
// Who can pass this token to MintOAuthTokenViaGrant to get an OAuth token.
@@ -38,7 +36,7 @@ message OAuthTokenGrantBody {
// A string of the form "user:<email>". On Swarming, this is an identity of
// a user that posted the task.
//
- // This is informational field currently (not used in authorization checks).
+ // Used by MintOAuthTokenViaGrant to recheck that the access is still allowed.
string end_user = 4;
// When the token was generated (and when it becomes valid).
« no previous file with comments | « tokenserver/api/admin/v1/pb.discovery.go ('k') | tokenserver/api/oauth_token_grant.pb.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698