Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tokenserver/api/oauth_token_grant.pb.go

Issue 2986423002: tokenserver: Fix some mistakes in proto docs for new token grants feature. (Closed)
Patch Set: rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tokenserver/api/oauth_token_grant.proto ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tokenserver/api/oauth_token_grant.pb.go
diff --git a/tokenserver/api/oauth_token_grant.pb.go b/tokenserver/api/oauth_token_grant.pb.go
index efbb7b59f7fbc5acef1e574589c61c18cfe327bb..98d726cd3a757ae782201ccb3e67af6342ec89d6 100644
--- a/tokenserver/api/oauth_token_grant.pb.go
+++ b/tokenserver/api/oauth_token_grant.pb.go
@@ -25,9 +25,7 @@ type OAuthTokenGrantBody struct {
//
// TODO(vadimsh): It may later be used for revocation purposes.
TokenId int64 `protobuf:"varint,1,opt,name=token_id,json=tokenId" json:"token_id,omitempty"`
- // Service account identity the end user wants to act as.
- //
- // A string of the form "user:<email>".
+ // Service account email the end user wants to act as.
ServiceAccount string `protobuf:"bytes,2,opt,name=service_account,json=serviceAccount" json:"service_account,omitempty"`
// Who can pass this token to MintOAuthTokenViaGrant to get an OAuth token.
//
@@ -39,7 +37,7 @@ type OAuthTokenGrantBody struct {
// A string of the form "user:<email>". On Swarming, this is an identity of
// a user that posted the task.
//
- // This is informational field currently (not used in authorization checks).
+ // Used by MintOAuthTokenViaGrant to recheck that the access is still allowed.
EndUser string `protobuf:"bytes,4,opt,name=end_user,json=endUser" json:"end_user,omitempty"`
// When the token was generated (and when it becomes valid).
IssuedAt *google_protobuf.Timestamp `protobuf:"bytes,5,opt,name=issued_at,json=issuedAt" json:"issued_at,omitempty"`
« no previous file with comments | « tokenserver/api/oauth_token_grant.proto ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698