[Mac]Port browser_keyevents_browsertest.cc and browser_focus_uitest.cc to Mac.

[Mac]Port browser_keyevents_browsertest.cc and browser_focus_uitest.cc to Mac.

This CL includes:
1. Implementation of ui_test_utils_mac.mm
2. Fix for ui_controls_mac.mm
3. Port browser_keyevents_browsertest.cc to Mac and add some new tests for Mac.
4. Partially port browser_focus_uitest.cc to Mac, now can be compiled and run
on Mac but some tests fail.
5. Add two functions into ui_test_utils.h: HideNativeWindow() and
ShowAndFocusNativeWindow(). The latter one shows a window and grabs the input
focus, which is useful for tests depending on fake keyboard/mouse events.

Because browser_keyevents_browsertests.cc and browser_focus_uitest.cc
belong to interactive_ui_tests, which is not available on Mac (see
http://crbug.com/21276), in order to test them on Mac, you may want to
move them into browser_tests locally. But it won't work on build and try
bots, because these tests must be run with screen unlocked.

This CL depends on CL: http://codereview.chromium.org/2973004
and http://codereview.chromium.org/2805075

BUG=22515
Keyboard handling needs unit tests
BUG=48671
interactive_ui_test: BrowserKeyEventsTest.NormalKeyEvents is flaky
BUG=48936
Browser window is opened inactivated when running an InProcessBrowserTest.
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53840

[James Su, 2010-07-14 18:41:07]

I finally uploaded this CL, with some unresolved issues :) Please help review
it.

Regards
James Su

[Paweł Hajdan Jr., 2010-07-14 18:51:00]

Drive-by with some minor test comments.

http://codereview.chromium.org/2986004/diff/1/10
File chrome/browser/browser_focus_uitest.cc (right):

http://codereview.chromium.org/2986004/diff/1/10#newcode318
chrome/browser/browser_focus_uitest.cc:318: HTTPTestServer* server =
StartHTTPServer();
This needs ASSERT_TRUE(server) to avoid a flaky crash.

http://codereview.chromium.org/2986004/diff/1/10#newcode357
chrome/browser/browser_focus_uitest.cc:357: HTTPTestServer* server =
StartHTTPServer();
Same here.

http://codereview.chromium.org/2986004/diff/1/10#newcode409
chrome/browser/browser_focus_uitest.cc:409: HTTPTestServer* server =
StartHTTPServer();
And here, and other places in this file.

http://codereview.chromium.org/2986004/diff/1/11
File chrome/browser/browser_keyevents_browsertest.cc (right):

http://codereview.chromium.org/2986004/diff/1/11#newcode508
chrome/browser/browser_keyevents_browsertest.cc:508: HTTPTestServer* server =
StartHTTPServer();
Please NULL-check  |server| (ASSERT_TRUE). May apply to other places in this
file.

[John Grabowski, 2010-07-14 21:51:49]

+cc jmikhail since this has implications for Mac WebDriver support

From CL description, 
   "But it won't work on build and try bots, because these tests must be run
with screen unlocked."
File a new bug on that issue, cc everyone on the reviewers list.

LGTM.  Really great to see this shaping up.

http://codereview.chromium.org/2986004/diff/6001/7003
File base/keyboard_code_conversion_mac.h (right):

http://codereview.chromium.org/2986004/diff/6001/7003#newcode20
base/keyboard_code_conversion_mac.h:20: // |characterIgnoringModifiers|.
Possibly explain that we use windows keycodes for our keyboard unit tests.  (I
think that's true but you probably know this area better than I do at this
point)

Interestingly, the Linux file says WindowsCodeForBlah (e.g. convert linux -->
windows), where here you do MacCodeForWindows (e.g. windows --> mac).  One
wonders why they aren't consistent (e.g. both convert to "native" or both
convert "to windows").  Can you explain?

http://codereview.chromium.org/2986004/diff/6001/7004
File base/keyboard_code_conversion_mac.mm (right):

http://codereview.chromium.org/2986004/diff/6001/7004#newcode203
base/keyboard_code_conversion_mac.mm:203: int
MacKeyCodeForWindowsKeyCode(KeyboardCode keycode,
DCHECK if we return -1?

http://codereview.chromium.org/2986004/diff/6001/7006
File chrome/browser/automation/ui_controls_internal.h (right):

http://codereview.chromium.org/2986004/diff/6001/7006#newcode17
chrome/browser/automation/ui_controls_internal.h:17: ClickTask(MouseButton
button, int state, Task* followup)
Document followup=NULL case

http://codereview.chromium.org/2986004/diff/6001/7007
File chrome/browser/automation/ui_controls_linux.cc (right):

http://codereview.chromium.org/2986004/diff/6001/7007#newcode64
chrome/browser/automation/ui_controls_linux.cc:64: };
Don't we now need a "using ui_controls;" given ClickTask is now in a
non-anonymous namespace?

http://codereview.chromium.org/2986004/diff/6001/7008
File chrome/browser/automation/ui_controls_mac.mm (right):

http://codereview.chromium.org/2986004/diff/6001/7008#newcode28
chrome/browser/automation/ui_controls_mac.mm:28: // But [NSApplication
sendEvent:] causes problem when sending mouse click
causes a problem

http://codereview.chromium.org/2986004/diff/6001/7008#newcode32
chrome/browser/automation/ui_controls_mac.mm:32: // In this case, [NSApplication
sendEvent:] causes dead lock.
deadlock

http://codereview.chromium.org/2986004/diff/6001/7008#newcode39
chrome/browser/automation/ui_controls_mac.mm:39: // 1. Investigate why using
[NSApplication postEvent:atStart:] for keyboard
add bug #

http://codereview.chromium.org/2986004/diff/6001/7008#newcode219
chrome/browser/automation/ui_controls_mac.mm:219: NSPoint g_mouse_location = {
0, 0 };
!!! A little scary but perhaps it's the best option.

http://codereview.chromium.org/2986004/diff/6001/7009
File chrome/browser/browser_focus_uitest.cc (right):

http://codereview.chromium.org/2986004/diff/6001/7009#newcode158
chrome/browser/browser_focus_uitest.cc:158: BringBrowserWindowToFront();
Move all the calls to BringBrowserWindowToFront() into a method of
BrowserFocusTest named SetUp().

http://codereview.chromium.org/2986004/diff/6001/7017
File chrome/test/ui_test_utils_mac.mm (right):

http://codereview.chromium.org/2986004/diff/6001/7017#newcode58
chrome/test/ui_test_utils_mac.mm:58: // A hack to make sure an unbundled program
can get the input focus.
It's not a hack; that's how it's done!

http://codereview.chromium.org/2986004/diff/6001/7018
File chrome/test/ui_test_utils_win.cc (right):

http://codereview.chromium.org/2986004/diff/6001/7018#newcode53
chrome/test/ui_test_utils_win.cc:53: // get the input focus?
Windows has special rules about stealing focus so it may not be possible to do
so.

[James Su, 2010-07-16 06:47:45]

http://codereview.chromium.org/2986004/diff/1/10
File chrome/browser/browser_focus_uitest.cc (right):

http://codereview.chromium.org/2986004/diff/1/10#newcode318
chrome/browser/browser_focus_uitest.cc:318: HTTPTestServer* server =
StartHTTPServer();
On 2010/07/14 18:51:02, Paweł Hajdan Jr. wrote:
> This needs ASSERT_TRUE(server) to avoid a flaky crash.

Done.

http://codereview.chromium.org/2986004/diff/1/10#newcode357
chrome/browser/browser_focus_uitest.cc:357: HTTPTestServer* server =
StartHTTPServer();
On 2010/07/14 18:51:02, Paweł Hajdan Jr. wrote:
> Same here.

Done.

http://codereview.chromium.org/2986004/diff/1/10#newcode409
chrome/browser/browser_focus_uitest.cc:409: HTTPTestServer* server =
StartHTTPServer();
On 2010/07/14 18:51:02, Paweł Hajdan Jr. wrote:
> And here, and other places in this file.

Done.

http://codereview.chromium.org/2986004/diff/6001/7003
File base/keyboard_code_conversion_mac.h (right):

http://codereview.chromium.org/2986004/diff/6001/7003#newcode20
base/keyboard_code_conversion_mac.h:20: // |characterIgnoringModifiers|.
On 2010/07/14 21:51:50, John Grabowski wrote:
> Possibly explain that we use windows keycodes for our keyboard unit tests.  (I
> think that's true but you probably know this area better than I do at this
> point)
> 
> Interestingly, the Linux file says WindowsCodeForBlah (e.g. convert linux -->
> windows), where here you do MacCodeForWindows (e.g. windows --> mac).  One
> wonders why they aren't consistent (e.g. both convert to "native" or both
> convert "to windows").  Can you explain?
> 
The Gtk version includes two functions for both direction.

http://codereview.chromium.org/2986004/diff/6001/7004
File base/keyboard_code_conversion_mac.mm (right):

http://codereview.chromium.org/2986004/diff/6001/7004#newcode203
base/keyboard_code_conversion_mac.mm:203: int
MacKeyCodeForWindowsKeyCode(KeyboardCode keycode,
On 2010/07/14 21:51:50, John Grabowski wrote:
> DCHECK if we return -1?
> 

Done.

http://codereview.chromium.org/2986004/diff/6001/7006
File chrome/browser/automation/ui_controls_internal.h (right):

http://codereview.chromium.org/2986004/diff/6001/7006#newcode17
chrome/browser/automation/ui_controls_internal.h:17: ClickTask(MouseButton
button, int state, Task* followup)
On 2010/07/14 21:51:50, John Grabowski wrote:
> Document followup=NULL case
> 

Done.

http://codereview.chromium.org/2986004/diff/6001/7007
File chrome/browser/automation/ui_controls_linux.cc (right):

http://codereview.chromium.org/2986004/diff/6001/7007#newcode64
chrome/browser/automation/ui_controls_linux.cc:64: };
On 2010/07/14 21:51:50, John Grabowski wrote:
> Don't we now need a "using ui_controls;" given ClickTask is now in a
> non-anonymous namespace?
> 

This part is still enclosed by namespace ui_controls { }.

http://codereview.chromium.org/2986004/diff/6001/7008
File chrome/browser/automation/ui_controls_mac.mm (right):

http://codereview.chromium.org/2986004/diff/6001/7008#newcode28
chrome/browser/automation/ui_controls_mac.mm:28: // But [NSApplication
sendEvent:] causes problem when sending mouse click
On 2010/07/14 21:51:50, John Grabowski wrote:
> causes a problem 

Done.

http://codereview.chromium.org/2986004/diff/6001/7008#newcode32
chrome/browser/automation/ui_controls_mac.mm:32: // In this case, [NSApplication
sendEvent:] causes dead lock.
On 2010/07/14 21:51:50, John Grabowski wrote:
> deadlock

Done.

http://codereview.chromium.org/2986004/diff/6001/7008#newcode39
chrome/browser/automation/ui_controls_mac.mm:39: // 1. Investigate why using
[NSApplication postEvent:atStart:] for keyboard
On 2010/07/14 21:51:50, John Grabowski wrote:
> add bug #

Done.

http://codereview.chromium.org/2986004/diff/6001/7009
File chrome/browser/browser_focus_uitest.cc (right):

http://codereview.chromium.org/2986004/diff/6001/7009#newcode158
chrome/browser/browser_focus_uitest.cc:158: BringBrowserWindowToFront();
On 2010/07/14 21:51:50, John Grabowski wrote:
> Move all the calls to BringBrowserWindowToFront() into a method of
> BrowserFocusTest named SetUp().
> 
We can't do that. InProcessBrowserTest does not provide such a method which will
be called just after creating the browser object and before executing the test
code. Maybe we should file a bug and add one.

http://codereview.chromium.org/2986004/diff/6001/7017
File chrome/test/ui_test_utils_mac.mm (right):

http://codereview.chromium.org/2986004/diff/6001/7017#newcode58
chrome/test/ui_test_utils_mac.mm:58: // A hack to make sure an unbundled program
can get the input focus.
On 2010/07/14 21:51:50, John Grabowski wrote:
> It's not a hack; that's how it's done!
> 

Done.

http://codereview.chromium.org/2986004/diff/6001/7018
File chrome/test/ui_test_utils_win.cc (right):

http://codereview.chromium.org/2986004/diff/6001/7018#newcode53
chrome/test/ui_test_utils_win.cc:53: // get the input focus?
On 2010/07/14 21:51:50, John Grabowski wrote:
> Windows has special rules about stealing focus so it may not be possible to do
> so.
Comment removed.

[John Grabowski, 2010-07-16 18:17:40]

Still LGTM

http://codereview.chromium.org/2986004/diff/6001/7009
File chrome/browser/browser_focus_uitest.cc (right):

http://codereview.chromium.org/2986004/diff/6001/7009#newcode158
chrome/browser/browser_focus_uitest.cc:158: BringBrowserWindowToFront();
On 2010/07/16 06:47:45, James Su wrote:
> On 2010/07/14 21:51:50, John Grabowski wrote:
> > Move all the calls to BringBrowserWindowToFront() into a method of
> > BrowserFocusTest named SetUp().
> > 
> We can't do that. InProcessBrowserTest does not provide such a method which
will
> be called just after creating the browser object and before executing the test
> code. Maybe we should file a bug and add one.
> 

Definitely add one.  Is a standard pattern for unit tests; someone will get a
nasty surprise if they add a SetUp() which mysteriously doesn't get called.

[Nico, 2010-07-16 18:24:36]

Only glossed over, but looked good.

http://codereview.chromium.org/2986004/diff/16001/17008
File chrome/browser/automation/ui_controls_mac.mm (right):

http://codereview.chromium.org/2986004/diff/16001/17008#newcode76
chrome/browser/automation/ui_controls_mac.mm:76: // Creates and returns a key
event. Passes ownership to the caller.
This is not true; this returns an autoreleased object.

[Paweł Hajdan Jr., 2010-07-16 18:34:45]

Code I commented in the drive-by LGTM. Thanks for adding the checks in all
places, this is going to make our tests much less crashy.

[James Su, 2010-07-16 20:05:39]

On 2010/07/16 18:17:40, John Grabowski wrote:
> Still LGTM
> 
> http://codereview.chromium.org/2986004/diff/6001/7009
> File chrome/browser/browser_focus_uitest.cc (right):
> 
> http://codereview.chromium.org/2986004/diff/6001/7009#newcode158
> chrome/browser/browser_focus_uitest.cc:158: BringBrowserWindowToFront();
> On 2010/07/16 06:47:45, James Su wrote:
> > On 2010/07/14 21:51:50, John Grabowski wrote:
> > > Move all the calls to BringBrowserWindowToFront() into a method of
> > > BrowserFocusTest named SetUp().
> > > 
> > We can't do that. InProcessBrowserTest does not provide such a method which
> will
> > be called just after creating the browser object and before executing the
test
> > code. Maybe we should file a bug and add one.
> > 
> 
> Definitely add one.  Is a standard pattern for unit tests; someone will get a
> nasty surprise if they add a SetUp() which mysteriously doesn't get called.
Filed a separated bug: http://code.google.com/p/chromium/issues/detail?id=49355

[Nico, 2010-07-19 16:55:55]

http://codereview.chromium.org/2986004/diff/16001/17009
File chrome/browser/browser_focus_uitest.cc (right):

http://codereview.chromium.org/2986004/diff/16001/17009#newcode740
chrome/browser/browser_focus_uitest.cc:740: BringBrowserWindowToFront();
Since you do this in every test, could you do it in SetUp() instead?

[James Su, 2010-07-19 17:06:42]

http://codereview.chromium.org/2986004/diff/16001/17009
File chrome/browser/browser_focus_uitest.cc (right):

http://codereview.chromium.org/2986004/diff/16001/17009#newcode740
chrome/browser/browser_focus_uitest.cc:740: BringBrowserWindowToFront();
On 2010/07/19 16:55:55, Nico wrote:
> Since you do this in every test, could you do it in SetUp() instead?

See http://crbug.com/49355

[James Su, 2010-07-21 03:42:30]

The CL has been updated to enable these two tests on Mac. Two issues were found
by running BrowserFocusTest:
http://crbug.com/49737
http://crbug.com/49738

Now the only thing to be solved before committing this CL is: make
InProcessBrowserTest runnable in interactive_ui_tests. When I tried it, I got
following error:

Note: Google Test filter = BrowserKeyEventsTest.NormalKeyEvents
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from BrowserKeyEventsTest
[ RUN      ] BrowserKeyEventsTest.NormalKeyEvents
2010-07-20 16:15:46.958 interactive_ui_tests[13911:107] Unknown class
'ChromeUILocalizer', using 'NSObject' instead. Encountered in Interface Builder
file at path /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
Framework.framework/Resources/MainMenu.nib.
[13911:263:0720/161546:714338559367653:ERROR:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/first_run_mac.mm(63)]
Not implemented reached in static bool FirstRun::ProcessMasterPreferences(const
FilePath&, FirstRun::MasterPrefs*)
[13911:263:0720/161546:714338568206627:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/extensions/extensions_service.cc(627)]
Sending EXTENSION_LOADED
[13911:22787:0720/161546:714338570207542:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/net/predictor_api.cc(544)]
DNS Prefetch service started
[13911:263:0720/161547:714338890462623:INFO:/Users/Shared/suzhe/devels/chrome/src/webkit/support/../glue/plugins/plugin_list.cc(214)]
Loaded plugin list in 320 ms.
[13911:22019:0720/161547:714338941070847:WARNING:/Users/Shared/suzhe/devels/chrome/src/net/base/file_stream_posix.cc(350)]
Failed to open file: 2
(/private/var/folders/++/++0in+++6+0++4RjPqRgNE++fgk/-Tmp-/.org.chromium.Iu3hdH/test_user_data/Default/Last
Tabs)
[13911:263:0720/161547:714338958702561:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(103)]
Unofficial build, using dev channel sync server.
[13911:263:0720/161547:714338958821524:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(129)]
Starting ProfileSyncService.
[13911:263:0720/161547:714338958848286:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(197)]
Using https://clients4.google.com/chrome-sync/dev for sync server URL.
[13911:263:0720/161547:714338959001381:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(352)]
Clearing Sync DB.
2010-07-20 16:15:47.407 interactive_ui_tests[13911:107] Unknown class
'TabStripView', using 'NSView' instead. Encountered in Interface Builder file at
path /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
Framework.framework/Resources/BrowserWindow.nib.
2010-07-20 16:15:47.408 interactive_ui_tests[13911:107] Unknown class
'SideTabStripView', using 'NSView' instead. Encountered in Interface Builder
file at path /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
Framework.framework/Resources/BrowserWindow.nib.
2010-07-20 16:15:47.409 interactive_ui_tests[13911:107] Unknown Window class
ChromeBrowserWindow in Interface Builder file,
	 creating generic Window instead
2010-07-20 16:15:47.412 interactive_ui_tests[13911:107] Unknown class
'FastResizeView', using 'NSView' instead. Encountered in Interface Builder file
at path /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
Framework.framework/Resources/BrowserWindow.nib.
2010-07-20 16:15:47.414 interactive_ui_tests[13911:107]
-[BrowserWindowController createTabStripController]: unrecognized selector sent
to instance 0x86445b0
[13911:263:0720/161547:714339002690143:ERROR:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/chrome_browser_application_mac.mm(62)]
Someone is preparing to raise an exception!  NSInvalidArgumentException ***
-[BrowserWindowController createTabStripController]: unrecognized selector sent
to instance 0x86445b0
[13911:263:0720/161547:714339002732121:FATAL:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/chrome_browser_application_mac.mm(65)]
Check failed: false. 
Backtrace:
	0   interactive_ui_tests                0x0000ed58 StackTrace::StackTrace() +
32
	1   interactive_ui_tests                0x0000ffb3
logging::LogMessage::~LogMessage() + 63
	2   interactive_ui_tests                0x00be8a89
-[NSException(NSExceptionSwizzle) chromeInitWithName:reason:userInfo:] + 594
	3   CoreFoundation                      0x9347a947 +[NSException
exceptionWithName:reason:userInfo:] + 87
	4   CoreFoundation                      0x934c78d3 -[NSObject(NSObject)
doesNotRecognizeSelector:] + 179
	5   CoreFoundation                      0x934217e6 ___forwarding___ + 950
	6   CoreFoundation                      0x934213b2 _CF_forwarding_prep_0 + 50
	7   interactive_ui_tests                0x00c27047 -[BrowserWindowController
initWithBrowser:takeOwnership:] + 1064
	8   interactive_ui_tests                0x00c216f9 -[BrowserWindowController
initWithBrowser:] + 51
	9   interactive_ui_tests                0x00bfe6aa
BrowserWindow::CreateBrowserWindow(Browser*) + 72
	10  interactive_ui_tests                0x00b5c67d
Browser::CreateBrowserWindow() + 249
	11  interactive_ui_tests                0x00b5e800 Browser::Create(Profile*) +
58
	12  interactive_ui_tests                0x0007d905
InProcessBrowserTest::CreateBrowser(Profile*) + 27
	13  interactive_ui_tests                0x0007d7b6
InProcessBrowserTest::RunTestOnMainThreadLoop() + 304
	14  interactive_ui_tests                0x0007f52a void
DispatchToMethod<InProcessBrowserTest, void
(InProcessBrowserTest::*)()>(InProcessBrowserTest*, void
(InProcessBrowserTest::*)(), Tuple0 const&) + 56
	15  interactive_ui_tests                0x0007f565
RunnableMethod<InProcessBrowserTest, void (InProcessBrowserTest::*)(),
Tuple0>::Run() + 57
	16  interactive_ui_tests                0x00b7d3fe
BrowserMain(MainFunctionParams const&) + 6084
	17  interactive_ui_tests                0x0007e9d6
InProcessBrowserTest::SetUp() + 3512
	18  interactive_ui_tests                0x002c691d testing::Test::Run() + 73
	19  interactive_ui_tests                0x002ca981
testing::internal::TestInfoImpl::Run() + 189
	20  interactive_ui_tests                0x002caac4 testing::TestCase::Run() +
186
	21  interactive_ui_tests                0x002cb6fe
testing::internal::UnitTestImpl::RunAllTests() + 658
	22  interactive_ui_tests                0x002cb890 testing::UnitTest::Run() +
20
	23  interactive_ui_tests                0x00085ec0 TestSuite::Run() + 304
	24  interactive_ui_tests                0x00084006 main + 1032
	25  interactive_ui_tests                0x00064c06 start + 54
	26  ???                                 0x00000006 0x0 + 6

[John Grabowski, 2010-07-21 17:02:46]

Perhaps you can sync/merge and try again?  There are a number of errors
which indicate mismatch; e.g.

2010-07-20 16:15:46.958 interactive_ui_tests[13911:107] Unknown class
'ChromeUILocalizer', using 'NSObject' instead. Encountered in Interface
Builder
file at path /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
Framework.framework/Resources/MainMenu.nib.

010-07-20 16:15:47.412 interactive_ui_tests[13911:107] Unknown class
'FastResizeView', using 'NSView' instead. Encountered in Interface Builder
file
at path /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
Framework.framework/Resources/BrowserWindow.nib.
2010-07-20 16


jrg


On Tue, Jul 20, 2010 at 8:42 PM, <suzhe@chromium.org> wrote:

> The CL has been updated to enable these two tests on Mac. Two issues were
> found
> by running BrowserFocusTest:
> http://crbug.com/49737
> http://crbug.com/49738
>
> Now the only thing to be solved before committing this CL is: make
> InProcessBrowserTest runnable in interactive_ui_tests. When I tried it, I
> got
> following error:
>
> Note: Google Test filter = BrowserKeyEventsTest.NormalKeyEvents
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from BrowserKeyEventsTest
> [ RUN      ] BrowserKeyEventsTest.NormalKeyEvents
> 2010-07-20 16:15:46.958 interactive_ui_tests[13911:107] Unknown class
> 'ChromeUILocalizer', using 'NSObject' instead. Encountered in Interface
> Builder
> file at path
> /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
> Framework.framework/Resources/MainMenu.nib.
>
>
[13911:263:0720/161546:714338559367653:ERROR:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/
> first_run_mac.mm(63)]
> Not implemented reached in static bool
> FirstRun::ProcessMasterPreferences(const
> FilePath&, FirstRun::MasterPrefs*)
>
>
[13911:263:0720/161546:714338568206627:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/extensions/extensions_service.cc(627)]
> Sending EXTENSION_LOADED
>
>
[13911:22787:0720/161546:714338570207542:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/net/predictor_api.cc(544)]
> DNS Prefetch service started
>
>
[13911:263:0720/161547:714338890462623:INFO:/Users/Shared/suzhe/devels/chrome/src/webkit/support/../glue/plugins/plugin_list.cc(214)]
> Loaded plugin list in 320 ms.
>
>
[13911:22019:0720/161547:714338941070847:WARNING:/Users/Shared/suzhe/devels/chrome/src/net/base/file_stream_posix.cc(350)]
> Failed to open file: 2
>
>
(/private/var/folders/++/++0in+++6+0++4RjPqRgNE++fgk/-Tmp-/.org.chromium.Iu3hdH/test_user_data/Default/Last
> Tabs)
>
>
[13911:263:0720/161547:714338958702561:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(103)]
> Unofficial build, using dev channel sync server.
>
>
[13911:263:0720/161547:714338958821524:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(129)]
> Starting ProfileSyncService.
>
>
[13911:263:0720/161547:714338958848286:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(197)]
> Using https://clients4.google.com/chrome-sync/dev for sync server URL.
>
>
[13911:263:0720/161547:714338959001381:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(352)]
> Clearing Sync DB.
> 2010-07-20 16:15:47.407 interactive_ui_tests[13911:107] Unknown class
> 'TabStripView', using 'NSView' instead. Encountered in Interface Builder
> file at
> path /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
> Framework.framework/Resources/BrowserWindow.nib.
> 2010-07-20 16:15:47.408 interactive_ui_tests[13911:107] Unknown class
> 'SideTabStripView', using 'NSView' instead. Encountered in Interface
> Builder
> file at path
> /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
> Framework.framework/Resources/BrowserWindow.nib.
> 2010-07-20 16:15:47.409 interactive_ui_tests[13911:107] Unknown Window
> class
> ChromeBrowserWindow in Interface Builder file,
>         creating generic Window instead
> 2010-07-20 16:15:47.412 interactive_ui_tests[13911:107] Unknown class
> 'FastResizeView', using 'NSView' instead. Encountered in Interface Builder
> file
> at path /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
> Framework.framework/Resources/BrowserWindow.nib.
> 2010-07-20 16:15:47.414 interactive_ui_tests[13911:107]
> -[BrowserWindowController createTabStripController]: unrecognized selector
> sent
> to instance 0x86445b0
>
>
[13911:263:0720/161547:714339002690143:ERROR:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/
> chrome_browser_application_mac.mm(62)]
> Someone is preparing to raise an exception!  NSInvalidArgumentException ***
> -[BrowserWindowController createTabStripController]: unrecognized selector
> sent
> to instance 0x86445b0
>
>
[13911:263:0720/161547:714339002732121:FATAL:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/
> chrome_browser_application_mac.mm(65)]
> Check failed: false.
> Backtrace:
>        0   interactive_ui_tests                0x0000ed58
> StackTrace::StackTrace() +
> 32
>        1   interactive_ui_tests                0x0000ffb3
> logging::LogMessage::~LogMessage() + 63
>        2   interactive_ui_tests                0x00be8a89
> -[NSException(NSExceptionSwizzle) chromeInitWithName:reason:userInfo:] +
> 594
>        3   CoreFoundation                      0x9347a947 +[NSException
> exceptionWithName:reason:userInfo:] + 87
>        4   CoreFoundation                      0x934c78d3
> -[NSObject(NSObject)
> doesNotRecognizeSelector:] + 179
>        5   CoreFoundation                      0x934217e6 ___forwarding___
> + 950
>        6   CoreFoundation                      0x934213b2
> _CF_forwarding_prep_0 + 50
>        7   interactive_ui_tests                0x00c27047
> -[BrowserWindowController
> initWithBrowser:takeOwnership:] + 1064
>        8   interactive_ui_tests                0x00c216f9
> -[BrowserWindowController
> initWithBrowser:] + 51
>        9   interactive_ui_tests                0x00bfe6aa
> BrowserWindow::CreateBrowserWindow(Browser*) + 72
>        10  interactive_ui_tests                0x00b5c67d
> Browser::CreateBrowserWindow() + 249
>        11  interactive_ui_tests                0x00b5e800
> Browser::Create(Profile*) +
> 58
>        12  interactive_ui_tests                0x0007d905
> InProcessBrowserTest::CreateBrowser(Profile*) + 27
>        13  interactive_ui_tests                0x0007d7b6
> InProcessBrowserTest::RunTestOnMainThreadLoop() + 304
>        14  interactive_ui_tests                0x0007f52a void
> DispatchToMethod<InProcessBrowserTest, void
> (InProcessBrowserTest::*)()>(InProcessBrowserTest*, void
> (InProcessBrowserTest::*)(), Tuple0 const&) + 56
>        15  interactive_ui_tests                0x0007f565
> RunnableMethod<InProcessBrowserTest, void (InProcessBrowserTest::*)(),
> Tuple0>::Run() + 57
>        16  interactive_ui_tests                0x00b7d3fe
> BrowserMain(MainFunctionParams const&) + 6084
>        17  interactive_ui_tests                0x0007e9d6
> InProcessBrowserTest::SetUp() + 3512
>        18  interactive_ui_tests                0x002c691d
> testing::Test::Run() + 73
>        19  interactive_ui_tests                0x002ca981
> testing::internal::TestInfoImpl::Run() + 189
>        20  interactive_ui_tests                0x002caac4
> testing::TestCase::Run() +
> 186
>        21  interactive_ui_tests                0x002cb6fe
> testing::internal::UnitTestImpl::RunAllTests() + 658
>        22  interactive_ui_tests                0x002cb890
> testing::UnitTest::Run() +
> 20
>        23  interactive_ui_tests                0x00085ec0 TestSuite::Run()
> + 304
>        24  interactive_ui_tests                0x00084006 main + 1032
>        25  interactive_ui_tests                0x00064c06 start + 54
>        26  ???                                 0x00000006 0x0 + 6
>
>
> http://codereview.chromium.org/2986004/show
>

[James Su, 2010-07-21 17:04:22]

I tried but no help.

Regards
James Su

在 2010年7月21日 上午10:02，John Grabowski <jrg@chromium.org>写道：

> Perhaps you can sync/merge and try again?  There are a number of errors
> which indicate mismatch; e.g.
>
>  2010-07-20 16:15:46.958 interactive_ui_tests[13911:107] Unknown class
> 'ChromeUILocalizer', using 'NSObject' instead. Encountered in Interface
> Builder
> file at path
> /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
> Framework.framework/Resources/MainMenu.nib.
>
> 010-07-20 16:15:47.412 interactive_ui_tests[13911:107] Unknown class
> 'FastResizeView', using 'NSView' instead. Encountered in Interface Builder
> file
> at path /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
> Framework.framework/Resources/BrowserWindow.nib.
> 2010-07-20 16
>
>
> jrg
>
>
> On Tue, Jul 20, 2010 at 8:42 PM, <suzhe@chromium.org> wrote:
>
>> The CL has been updated to enable these two tests on Mac. Two issues were
>> found
>> by running BrowserFocusTest:
>> http://crbug.com/49737
>> http://crbug.com/49738
>>
>> Now the only thing to be solved before committing this CL is: make
>> InProcessBrowserTest runnable in interactive_ui_tests. When I tried it, I
>> got
>> following error:
>>
>> Note: Google Test filter = BrowserKeyEventsTest.NormalKeyEvents
>> [==========] Running 1 test from 1 test case.
>> [----------] Global test environment set-up.
>> [----------] 1 test from BrowserKeyEventsTest
>> [ RUN      ] BrowserKeyEventsTest.NormalKeyEvents
>> 2010-07-20 16:15:46.958 interactive_ui_tests[13911:107] Unknown class
>> 'ChromeUILocalizer', using 'NSObject' instead. Encountered in Interface
>> Builder
>> file at path
>> /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
>> Framework.framework/Resources/MainMenu.nib.
>>
>>
[13911:263:0720/161546:714338559367653:ERROR:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/
>> first_run_mac.mm(63)]
>> Not implemented reached in static bool
>> FirstRun::ProcessMasterPreferences(const
>> FilePath&, FirstRun::MasterPrefs*)
>>
>>
[13911:263:0720/161546:714338568206627:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/extensions/extensions_service.cc(627)]
>> Sending EXTENSION_LOADED
>>
>>
[13911:22787:0720/161546:714338570207542:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/net/predictor_api.cc(544)]
>> DNS Prefetch service started
>>
>>
[13911:263:0720/161547:714338890462623:INFO:/Users/Shared/suzhe/devels/chrome/src/webkit/support/../glue/plugins/plugin_list.cc(214)]
>> Loaded plugin list in 320 ms.
>>
>>
[13911:22019:0720/161547:714338941070847:WARNING:/Users/Shared/suzhe/devels/chrome/src/net/base/file_stream_posix.cc(350)]
>> Failed to open file: 2
>>
>>
(/private/var/folders/++/++0in+++6+0++4RjPqRgNE++fgk/-Tmp-/.org.chromium.Iu3hdH/test_user_data/Default/Last
>> Tabs)
>>
>>
[13911:263:0720/161547:714338958702561:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(103)]
>> Unofficial build, using dev channel sync server.
>>
>>
[13911:263:0720/161547:714338958821524:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(129)]
>> Starting ProfileSyncService.
>>
>>
[13911:263:0720/161547:714338958848286:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(197)]
>> Using https://clients4.google.com/chrome-sync/dev for sync server URL.
>>
>>
[13911:263:0720/161547:714338959001381:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(352)]
>> Clearing Sync DB.
>> 2010-07-20 16:15:47.407 interactive_ui_tests[13911:107] Unknown class
>> 'TabStripView', using 'NSView' instead. Encountered in Interface Builder
>> file at
>> path /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
>> Framework.framework/Resources/BrowserWindow.nib.
>> 2010-07-20 16:15:47.408 interactive_ui_tests[13911:107] Unknown class
>> 'SideTabStripView', using 'NSView' instead. Encountered in Interface
>> Builder
>> file at path
>> /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
>> Framework.framework/Resources/BrowserWindow.nib.
>> 2010-07-20 16:15:47.409 interactive_ui_tests[13911:107] Unknown Window
>> class
>> ChromeBrowserWindow in Interface Builder file,
>>         creating generic Window instead
>> 2010-07-20 16:15:47.412 interactive_ui_tests[13911:107] Unknown class
>> 'FastResizeView', using 'NSView' instead. Encountered in Interface Builder
>> file
>> at path /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
>> Framework.framework/Resources/BrowserWindow.nib.
>> 2010-07-20 16:15:47.414 interactive_ui_tests[13911:107]
>> -[BrowserWindowController createTabStripController]: unrecognized selector
>> sent
>> to instance 0x86445b0
>>
>>
[13911:263:0720/161547:714339002690143:ERROR:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/
>> chrome_browser_application_mac.mm(62)]
>> Someone is preparing to raise an exception!  NSInvalidArgumentException
>> ***
>> -[BrowserWindowController createTabStripController]: unrecognized selector
>> sent
>> to instance 0x86445b0
>>
>>
[13911:263:0720/161547:714339002732121:FATAL:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/
>> chrome_browser_application_mac.mm(65)]
>> Check failed: false.
>> Backtrace:
>>        0   interactive_ui_tests                0x0000ed58
>> StackTrace::StackTrace() +
>> 32
>>        1   interactive_ui_tests                0x0000ffb3
>> logging::LogMessage::~LogMessage() + 63
>>        2   interactive_ui_tests                0x00be8a89
>> -[NSException(NSExceptionSwizzle) chromeInitWithName:reason:userInfo:] +
>> 594
>>        3   CoreFoundation                      0x9347a947 +[NSException
>> exceptionWithName:reason:userInfo:] + 87
>>        4   CoreFoundation                      0x934c78d3
>> -[NSObject(NSObject)
>> doesNotRecognizeSelector:] + 179
>>        5   CoreFoundation                      0x934217e6 ___forwarding___
>> + 950
>>        6   CoreFoundation                      0x934213b2
>> _CF_forwarding_prep_0 + 50
>>        7   interactive_ui_tests                0x00c27047
>> -[BrowserWindowController
>> initWithBrowser:takeOwnership:] + 1064
>>        8   interactive_ui_tests                0x00c216f9
>> -[BrowserWindowController
>> initWithBrowser:] + 51
>>        9   interactive_ui_tests                0x00bfe6aa
>> BrowserWindow::CreateBrowserWindow(Browser*) + 72
>>        10  interactive_ui_tests                0x00b5c67d
>> Browser::CreateBrowserWindow() + 249
>>        11  interactive_ui_tests                0x00b5e800
>> Browser::Create(Profile*) +
>> 58
>>        12  interactive_ui_tests                0x0007d905
>> InProcessBrowserTest::CreateBrowser(Profile*) + 27
>>        13  interactive_ui_tests                0x0007d7b6
>> InProcessBrowserTest::RunTestOnMainThreadLoop() + 304
>>        14  interactive_ui_tests                0x0007f52a void
>> DispatchToMethod<InProcessBrowserTest, void
>> (InProcessBrowserTest::*)()>(InProcessBrowserTest*, void
>> (InProcessBrowserTest::*)(), Tuple0 const&) + 56
>>        15  interactive_ui_tests                0x0007f565
>> RunnableMethod<InProcessBrowserTest, void (InProcessBrowserTest::*)(),
>> Tuple0>::Run() + 57
>>        16  interactive_ui_tests                0x00b7d3fe
>> BrowserMain(MainFunctionParams const&) + 6084
>>        17  interactive_ui_tests                0x0007e9d6
>> InProcessBrowserTest::SetUp() + 3512
>>        18  interactive_ui_tests                0x002c691d
>> testing::Test::Run() + 73
>>        19  interactive_ui_tests                0x002ca981
>> testing::internal::TestInfoImpl::Run() + 189
>>        20  interactive_ui_tests                0x002caac4
>> testing::TestCase::Run() +
>> 186
>>        21  interactive_ui_tests                0x002cb6fe
>> testing::internal::UnitTestImpl::RunAllTests() + 658
>>        22  interactive_ui_tests                0x002cb890
>> testing::UnitTest::Run() +
>> 20
>>        23  interactive_ui_tests                0x00085ec0 TestSuite::Run()
>> + 304
>>        24  interactive_ui_tests                0x00084006 main + 1032
>>        25  interactive_ui_tests                0x00064c06 start + 54
>>        26  ???                                 0x00000006 0x0 + 6
>>
>>
>> http://codereview.chromium.org/2986004/show
>>
>
>

[Nico, 2010-07-21 21:18:33]

On 2010/07/21 03:42:30, James Su wrote:
> The CL has been updated to enable these two tests on Mac. Two issues were
found
> by running BrowserFocusTest:
> http://crbug.com/49737
> http://crbug.com/49738
> 
> Now the only thing to be solved before committing this CL is: make
> InProcessBrowserTest runnable in interactive_ui_tests. When I tried it, I got
> following error:
> 
> Note: Google Test filter = BrowserKeyEventsTest.NormalKeyEvents
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from BrowserKeyEventsTest
> [ RUN      ] BrowserKeyEventsTest.NormalKeyEvents
> 2010-07-20 16:15:46.958 interactive_ui_tests[13911:107] Unknown class
> 'ChromeUILocalizer', using 'NSObject' instead. Encountered in Interface
Builder
> file at path /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
> Framework.framework/Resources/MainMenu.nib.
>
[13911:263:0720/161546:714338559367653:ERROR:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/first_run_mac.mm(63)]
> Not implemented reached in static bool
FirstRun::ProcessMasterPreferences(const
> FilePath&, FirstRun::MasterPrefs*)
>
[13911:263:0720/161546:714338568206627:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/extensions/extensions_service.cc(627)]
> Sending EXTENSION_LOADED
>
[13911:22787:0720/161546:714338570207542:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/net/predictor_api.cc(544)]
> DNS Prefetch service started
>
[13911:263:0720/161547:714338890462623:INFO:/Users/Shared/suzhe/devels/chrome/src/webkit/support/../glue/plugins/plugin_list.cc(214)]
> Loaded plugin list in 320 ms.
>
[13911:22019:0720/161547:714338941070847:WARNING:/Users/Shared/suzhe/devels/chrome/src/net/base/file_stream_posix.cc(350)]
> Failed to open file: 2
>
(/private/var/folders/++/++0in+++6+0++4RjPqRgNE++fgk/-Tmp-/.org.chromium.Iu3hdH/test_user_data/Default/Last
> Tabs)
>
[13911:263:0720/161547:714338958702561:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(103)]
> Unofficial build, using dev channel sync server.
>
[13911:263:0720/161547:714338958821524:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(129)]
> Starting ProfileSyncService.
>
[13911:263:0720/161547:714338958848286:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(197)]
> Using https://clients4.google.com/chrome-sync/dev for sync server URL.
>
[13911:263:0720/161547:714338959001381:INFO:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/sync/profile_sync_service.cc(352)]
> Clearing Sync DB.
> 2010-07-20 16:15:47.407 interactive_ui_tests[13911:107] Unknown class
> 'TabStripView', using 'NSView' instead. Encountered in Interface Builder file
at
> path /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
> Framework.framework/Resources/BrowserWindow.nib.
> 2010-07-20 16:15:47.408 interactive_ui_tests[13911:107] Unknown class
> 'SideTabStripView', using 'NSView' instead. Encountered in Interface Builder
> file at path /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
> Framework.framework/Resources/BrowserWindow.nib.
> 2010-07-20 16:15:47.409 interactive_ui_tests[13911:107] Unknown Window class
> ChromeBrowserWindow in Interface Builder file,
> 	 creating generic Window instead
> 2010-07-20 16:15:47.412 interactive_ui_tests[13911:107] Unknown class
> 'FastResizeView', using 'NSView' instead. Encountered in Interface Builder
file
> at path /Users/Shared/suzhe/devels/chrome/src/xcodebuild/Debug/Chromium
> Framework.framework/Resources/BrowserWindow.nib.
> 2010-07-20 16:15:47.414 interactive_ui_tests[13911:107]
> -[BrowserWindowController createTabStripController]: unrecognized selector
sent
> to instance 0x86445b0
>
[13911:263:0720/161547:714339002690143:ERROR:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/chrome_browser_application_mac.mm(62)]
> Someone is preparing to raise an exception!  NSInvalidArgumentException ***
> -[BrowserWindowController createTabStripController]: unrecognized selector
sent
> to instance 0x86445b0
>
[13911:263:0720/161547:714339002732121:FATAL:/Users/Shared/suzhe/devels/chrome/src/chrome/browser/chrome_browser_application_mac.mm(65)]
> Check failed: false. 
> Backtrace:
> 	0   interactive_ui_tests                0x0000ed58 StackTrace::StackTrace() +
> 32
> 	1   interactive_ui_tests                0x0000ffb3
> logging::LogMessage::~LogMessage() + 63
> 	2   interactive_ui_tests                0x00be8a89
> -[NSException(NSExceptionSwizzle) chromeInitWithName:reason:userInfo:] + 594
> 	3   CoreFoundation                      0x9347a947 +[NSException
> exceptionWithName:reason:userInfo:] + 87
> 	4   CoreFoundation                      0x934c78d3 -[NSObject(NSObject)
> doesNotRecognizeSelector:] + 179
> 	5   CoreFoundation                      0x934217e6 ___forwarding___ + 950
> 	6   CoreFoundation                      0x934213b2 _CF_forwarding_prep_0 + 50
> 	7   interactive_ui_tests                0x00c27047 -[BrowserWindowController
> initWithBrowser:takeOwnership:] + 1064
> 	8   interactive_ui_tests                0x00c216f9 -[BrowserWindowController
> initWithBrowser:] + 51
> 	9   interactive_ui_tests                0x00bfe6aa
> BrowserWindow::CreateBrowserWindow(Browser*) + 72
> 	10  interactive_ui_tests                0x00b5c67d
> Browser::CreateBrowserWindow() + 249
> 	11  interactive_ui_tests                0x00b5e800 Browser::Create(Profile*)
+
> 58
> 	12  interactive_ui_tests                0x0007d905
> InProcessBrowserTest::CreateBrowser(Profile*) + 27
> 	13  interactive_ui_tests                0x0007d7b6
> InProcessBrowserTest::RunTestOnMainThreadLoop() + 304
> 	14  interactive_ui_tests                0x0007f52a void
> DispatchToMethod<InProcessBrowserTest, void
> (InProcessBrowserTest::*)()>(InProcessBrowserTest*, void
> (InProcessBrowserTest::*)(), Tuple0 const&) + 56
> 	15  interactive_ui_tests                0x0007f565
> RunnableMethod<InProcessBrowserTest, void (InProcessBrowserTest::*)(),
> Tuple0>::Run() + 57
> 	16  interactive_ui_tests                0x00b7d3fe
> BrowserMain(MainFunctionParams const&) + 6084
> 	17  interactive_ui_tests                0x0007e9d6
> InProcessBrowserTest::SetUp() + 3512
> 	18  interactive_ui_tests                0x002c691d testing::Test::Run() + 73
> 	19  interactive_ui_tests                0x002ca981
> testing::internal::TestInfoImpl::Run() + 189
> 	20  interactive_ui_tests                0x002caac4 testing::TestCase::Run() +
> 186
> 	21  interactive_ui_tests                0x002cb6fe
> testing::internal::UnitTestImpl::RunAllTests() + 658
> 	22  interactive_ui_tests                0x002cb890 testing::UnitTest::Run() +
> 20
> 	23  interactive_ui_tests                0x00085ec0 TestSuite::Run() + 304
> 	24  interactive_ui_tests                0x00084006 main + 1032
> 	25  interactive_ui_tests                0x00064c06 start + 54
> 	26  ???                                 0x00000006 0x0 + 6

This is fixed by http://codereview.chromium.org/2847065

[James Su, 2010-07-21 22:59:09]

These tests work without any problem on my local machine. Is it ok to commit
this CL now?

[Nico, 2010-07-21 23:07:02]

On Wed, Jul 21, 2010 at 3:59 PM,  <suzhe@chromium.org> wrote:
> These tests work without any problem on my local machine. Is it ok to commit
> this CL now?

If you're not in a hurry, maybe you could wait until maruel did a
master restart (scheduled for this weekend). Until then
interactive_ui_tests isn't running on the bots anyway.

>
> http://codereview.chromium.org/2986004/show
>

[James Su, 2010-07-21 23:12:17]

Sounds good to me.

On 2010/07/21 23:07:02, Nico wrote:
> On Wed, Jul 21, 2010 at 3:59 PM,  <mailto:suzhe@chromium.org> wrote:
> > These tests work without any problem on my local machine. Is it ok to commit
> > this CL now?
> 
> If you're not in a hurry, maybe you could wait until maruel did a
> master restart (scheduled for this weekend). Until then
> interactive_ui_tests isn't running on the bots anyway.
> 
> >
> > http://codereview.chromium.org/2986004/show
> >
>