Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2847065: Mac: Let interactive_ui_tests load nibs. (Closed)

Created:
10 years, 5 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Mac: Let interactive_ui_tests load nibs. The problem was that all objc symbols get stripped, and the nib resolving mechanism relied on them. BUG=22515, 21276 TEST=Patch in http://codereview.chromium.org/2986004 , run `xcodebuild/Debug/interactive_ui_tests --gtest_filter=BrowserKeyEventsTest.NormalKeyEvents`. Shouldn't crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/test/interactive_ui/interactive_ui_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
10 years, 5 months ago (2010-07-21 21:19:47 UTC) #1
Mark Mentovai
10 years, 5 months ago (2010-07-21 21:22:05 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698