Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2985753003: swarming: Remove support for task without 'pool' dimension (Closed)

Created:
3 years, 5 months ago by M-A Ruel
Modified:
3 years, 5 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

swarming: Remove support for task without 'pool' dimension Previously, a task with 'id' would still be allowed when authenticating as an administrator. This change removes this one off. There is only one exception remaining: terminate task are still allowed to use 'id' only dimensions. R=vadimsh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2985753003 Committed: https://github.com/luci/luci-py/commit/3e13708cef8e22e52fbeb27935e762078a96917d

Patch Set 1 #

Patch Set 2 : Tweak comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M appengine/swarming/server/task_request.py View 1 3 chunks +7 lines, -5 lines 0 comments Download
M appengine/swarming/server/task_request_test.py View 1 chunk +4 lines, -1 line 0 comments Download
M appengine/swarming/server/task_scheduler.py View 1 chunk +0 lines, -10 lines 0 comments Download
M appengine/swarming/server/task_scheduler_test.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
M-A Ruel
I've split out the change to enforce pool as a separate CL because it's a ...
3 years, 5 months ago (2017-07-24 23:51:43 UTC) #1
Vadim Sh.
lgtm
3 years, 5 months ago (2017-07-25 00:34:11 UTC) #2
M-A Ruel
On 2017/07/25 00:34:11, Vadim Sh. wrote: > lgtm Improved the comments a bit in patchset ...
3 years, 5 months ago (2017-07-25 11:50:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2985753003/20001
3 years, 5 months ago (2017-07-25 11:51:15 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-07-25 11:54:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/3e13708cef8e22e52fbeb27935e762078a96917d

Powered by Google App Engine
This is Rietveld 408576698