appengine/swarming/server/task_request_test.py - Issue 2985753003: swarming: Remove support for task without 'pool' dimension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/swarming/server/task_request_test.py

Issue 2985753003: swarming: Remove support for task without 'pool' dimension (Closed)

Patch Set: Tweak comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/swarming/server/task_request_test.py

diff --git a/appengine/swarming/server/task_request_test.py b/appengine/swarming/server/task_request_test.py

index 619ee5f9d548cb3c29062dc972a943902d2d911c..894819fb18c3eecffadfce9e28435c208d34cd83 100755

--- a/appengine/swarming/server/task_request_test.py

+++ b/appengine/swarming/server/task_request_test.py

@@ -552,8 +552,11 @@ class TaskRequestApiTest(TestCase):

with self.assertRaises(datastore_errors.BadValueError):

mkreq(_gen_request(

properties=dict(dimensions={u'id': u'b', u'a:': u'b'})))

+ with self.assertRaises(datastore_errors.BadValueError):

+ mkreq(_gen_request(

+ properties=dict(dimensions={u'id': u'b', u'a.': u'b'})))

mkreq(_gen_request(

- properties=dict(dimensions={u'id': u'b', u'a.': u'b'})))

+ properties=dict(dimensions={u'id': u'b', u'pool': u'b'})))

# Environment.

with self.assertRaises(TypeError):