swarming: Remove support for task without 'pool' dimension

appengine/swarming/server/task_scheduler_test.py

 #!/usr/bin/env python
 # Copyright 2014 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 import datetime
 import logging
 import os
 import random
 import sys
 import unittest
 
 # Setups environment.
 APP_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
 sys.path.insert(0, APP_DIR)
 import test_env_handlers
 
+from google.appengine.api import datastore_errors
 from google.appengine.ext import ndb
 
 import webtest
 
 import event_mon_metrics
 import handlers_backend
 
 from components import auth
 from components import auth_testing
 from components import datastore_utils
@@ skipping 675 matching lines @@
 
   def test_schedule_request_forbidden_dim_via_star(self):
     self.mock_dim_acls({u'abc:*': u'noone'})
     self._quick_schedule(properties={'dimensions': {u'pool': u'default'}})
     with self.assertRaises(auth.AuthorizationError):
       self._quick_schedule(
         properties={'dimensions': {u'pool': u'default', u'abc': u'blah'}})
 
   def test_schedule_request_id_without_pool(self):
     self.mock_dim_acls({u'pool:good': u'mocked'})
-    with self.assertRaises(auth.AuthorizationError):
+    with self.assertRaises(datastore_errors.BadValueError):
       self._quick_schedule(properties={'dimensions': {u'id': u'abc'}})
     auth_testing.mock_is_admin(self)
-    self._quick_schedule(properties={'dimensions': {u'id': u'abc'}}, nb_task=0)
+    with self.assertRaises(datastore_errors.BadValueError):
+      self._quick_schedule(properties={'dimensions': {u'id': u'abc'}})
 
   def test_schedule_request_id_and_pool(self):
     self.mock_dim_acls({u'pool:good': u'mocked'})
     self.mock_dim_acls({u'pool:bad': u'unknown'})
 
     def mocked_is_group_member(group, ident):
       if group == 'mocked' and ident == auth_testing.DEFAULT_MOCKED_IDENTITY:
         return True
       return False
     self.mock(auth, 'is_group_member', mocked_is_group_member)
@@ skipping 656 matching lines @@
         (['1d69b9f088008911'], 0, 0),
         task_scheduler.cron_handle_bot_died('f.local'))
 
 
 if __name__ == '__main__':
   if '-v' in sys.argv:
     unittest.TestCase.maxDiff = None
   logging.basicConfig(
       level=logging.DEBUG if '-v' in sys.argv else logging.CRITICAL)
   unittest.main()