Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2984673002: [milo] get console in working shape. (Closed)

Created:
3 years, 5 months ago by iannucci
Modified:
3 years, 5 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M milo/buildsource/console.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M milo/common/config.go View 1 chunk +0 lines, -1 line 0 comments Download
M milo/frontend/appengine/templates/pages/console.html View 1 chunk +1 line, -1 line 0 comments Download
M milo/frontend/view_console.go View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
iannucci
3 years, 5 months ago (2017-07-20 08:09:10 UTC) #1
Ryan Tseng
lgtm
3 years, 5 months ago (2017-07-20 08:22:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2984673002/20001
3 years, 5 months ago (2017-07-20 08:22:56 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-07-20 08:28:44 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/f754e176983a7aead58c99222058c2a07222a73e

Powered by Google App Engine
This is Rietveld 408576698