Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: milo/buildsource/console.go

Issue 2984673002: [milo] get console in working shape. (Closed)
Patch Set: fix build Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | milo/common/config.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/buildsource/console.go
diff --git a/milo/buildsource/console.go b/milo/buildsource/console.go
index f38abdb78a0b567ec55a35fa7247554eb9b6ee39..1292f140572e0d4fd1b04d8c78c6d4fd6b900dac 100644
--- a/milo/buildsource/console.go
+++ b/milo/buildsource/console.go
@@ -61,14 +61,14 @@ func GetConsoleRows(c context.Context, project string, console *common.Console,
url = ""
}
partialKey := model.NewPartialManifestKey(project, console.ID, console.ManifestName, url)
- q := datastore.NewQuery("BuildSummary").KeysOnly(true)
+ q := datastore.NewQuery("BuildSummary")
err := parallel.WorkPool(4, func(ch chan<- func() error) {
for i := range rawCommits {
i := i
r := &ConsoleRow{Commit: commits[i]}
ret[i] = r
ch <- func() error {
- fullQ := q.Eq("ManifestKey", partialKey.AddRevision(rawCommits[i]))
+ fullQ := q.Eq("ManifestKeys", partialKey.AddRevision(rawCommits[i]))
return datastore.Run(c, fullQ, func(bs *model.BuildSummary) {
if builderSet.Has(bs.BuilderID) {
bid := BuilderID(bs.BuilderID)
« no previous file with comments | « no previous file | milo/common/config.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698