Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Issue 2984383002: Reland of Add deduplication logic to .pak files (Closed)

Created:
3 years, 4 months ago by agrieve
Modified:
3 years, 4 months ago
Reviewers:
flackr, achuithb, sadrul
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add deduplication logic to .pak files Revert was here: https://codereview.chromium.org/2989443002/ Reason for reland: No changes from origina. Bot issue fixed by: https://chromium-review.googlesource.com/c/589888/ Now, when multiple entries contain the same content, multiple table-of-contents entries will be created, but only one data region. As of now, en-US.pak has ~3200 entries, and 350 of them are duplicates. For MonochromePublic.apk, shrinks uncompressed .pak size by ~130kb, and compressed .pak size by 32kb. TBR=flackr@chromium.org,sadrul@chromium.org,achuith@chromium.org BUG=738566 Review-Url: https://codereview.chromium.org/2984383002 Cr-Commit-Position: refs/heads/master@{#490501} Committed: https://chromium.googlesource.com/chromium/src/+/4735fae6caad85ab08433367108d3b96c0f7d646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -238 lines) Patch
M build/android/resource_sizes.py View 1 chunk +9 lines, -4 lines 0 comments Download
M tools/grit/grit/format/data_pack.py View 2 chunks +80 lines, -34 lines 0 comments Download
M tools/grit/grit/format/data_pack_unittest.py View 3 chunks +42 lines, -7 lines 0 comments Download
M tools/grit/pak_util.py View 2 chunks +8 lines, -2 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/resource/data_pack.h View 2 chunks +6 lines, -1 line 0 comments Download
M ui/base/resource/data_pack.cc View 8 chunks +136 lines, -102 lines 0 comments Download
A ui/base/resource/data_pack_literal.h View 1 chunk +23 lines, -0 lines 0 comments Download
M ui/base/resource/data_pack_literal.cc View 1 chunk +62 lines, -48 lines 0 comments Download
M ui/base/resource/data_pack_unittest.cc View 7 chunks +51 lines, -30 lines 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 3 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
agrieve
Created Reland of Add deduplication logic to .pak files
3 years, 4 months ago (2017-07-28 17:54:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2984383002/1
3 years, 4 months ago (2017-07-28 17:56:49 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-07-28 20:39:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4735fae6caad85ab08433367108d...

Powered by Google App Engine
This is Rietveld 408576698