Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2989443002: Revert of Add deduplication logic to .pak files (Closed)

Created:
3 years, 5 months ago by achuithb
Modified:
3 years, 5 months ago
Reviewers:
flackr, sadrul, agrieve
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add deduplication logic to .pak files (patchset #10 id:180001 of https://codereview.chromium.org/2969123002/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=747171 Original issue's description: > Add deduplication logic to .pak files > > Now, when multiple entries contain the same content, multiple > table-of-contents entries will be created, but only one data region. > > As of now, en-US.pak has ~3200 entries, and 350 of them are duplicates. > > For MonochromePublic.apk, shrinks uncompressed .pak size by ~130kb, and > compressed .pak size by 32kb. > > BUG=738566 > > Review-Url: https://codereview.chromium.org/2969123002 > Cr-Commit-Position: refs/heads/master@{#488215} > Committed: https://chromium.googlesource.com/chromium/src/+/ade347f539a378fb37500f6d17e8835edc1d8ec0 TBR=flackr@chromium.org,sadrul@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=738566 Review-Url: https://codereview.chromium.org/2989443002 Cr-Commit-Position: refs/heads/master@{#488554} Committed: https://chromium.googlesource.com/chromium/src/+/59f00a7d06b43ae4127637baaf7d8e8f5ee7847a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -421 lines) Patch
M build/android/resource_sizes.py View 1 chunk +4 lines, -9 lines 0 comments Download
M tools/grit/grit/format/data_pack.py View 2 chunks +34 lines, -80 lines 0 comments Download
M tools/grit/grit/format/data_pack_unittest.py View 3 chunks +7 lines, -42 lines 0 comments Download
M tools/grit/pak_util.py View 2 chunks +2 lines, -8 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/resource/data_pack.h View 2 chunks +1 line, -6 lines 0 comments Download
M ui/base/resource/data_pack.cc View 8 chunks +102 lines, -136 lines 0 comments Download
D ui/base/resource/data_pack_literal.h View 1 chunk +0 lines, -23 lines 0 comments Download
M ui/base/resource/data_pack_literal.cc View 1 chunk +48 lines, -62 lines 0 comments Download
M ui/base/resource/data_pack_unittest.cc View 7 chunks +30 lines, -51 lines 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
achuithb
Created Revert of Add deduplication logic to .pak files
3 years, 5 months ago (2017-07-20 23:55:41 UTC) #1
agrieve
On 2017/07/20 23:55:41, achuithb wrote: > Created Revert of Add deduplication logic to .pak files ...
3 years, 5 months ago (2017-07-21 02:07:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2989443002/1
3 years, 5 months ago (2017-07-21 02:10:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/59f00a7d06b43ae4127637baaf7d8e8f5ee7847a
3 years, 5 months ago (2017-07-21 02:11:58 UTC) #7
agrieve
3 years, 4 months ago (2017-07-28 17:54:35 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2984383002/ by agrieve@chromium.org.

The reason for reverting is: sys.path fixed up in:
https://chromium-review.googlesource.com/c/589888/.

Powered by Google App Engine
This is Rietveld 408576698