Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2983293002: Remove toplevel inference restriction hints, and restore as much (Closed)

Created:
3 years, 5 months ago by Leaf
Modified:
3 years, 5 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove toplevel inference restriction hints, and restore as much toplevel inference as possible to match the new front end toplevel inference. BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c595972d746b750dea0c56c9ed767afb961f0d09

Patch Set 1 #

Patch Set 2 : Comment #

Patch Set 3 : Refactor #

Patch Set 4 : Keep error filter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+466 lines, -580 lines) Patch
M pkg/analyzer/lib/src/error/codes.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 1 2 13 chunks +110 lines, -63 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +14 lines, -42 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 2 3 5 chunks +5 lines, -51 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong_mode.dart View 5 chunks +2 lines, -113 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/summary/top_level_inference_test.dart View 35 chunks +282 lines, -243 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 6 chunks +6 lines, -8 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 9 chunks +32 lines, -21 lines 0 comments Download
M pkg/analyzer/test/src/task/strong_mode_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
This is my attempt to restore as much of the previous status quo as possible ...
3 years, 5 months ago (2017-07-21 19:50:24 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-07-23 23:09:15 UTC) #3
Leaf
3 years, 5 months ago (2017-07-25 22:57:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
c595972d746b750dea0c56c9ed767afb961f0d09 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698