Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: pkg/analyzer/test/src/task/strong/inferred_type_test.dart

Issue 2983293002: Remove toplevel inference restriction hints, and restore as much (Closed)
Patch Set: Keep error filter Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/task/dart_test.dart ('k') | pkg/analyzer/test/src/task/strong_mode_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/task/strong/inferred_type_test.dart
diff --git a/pkg/analyzer/test/src/task/strong/inferred_type_test.dart b/pkg/analyzer/test/src/task/strong/inferred_type_test.dart
index efc0677583d2f22aaf9e2f0be577abc459b60890..7a66f67f6f3cf2e2d61484a3ed8d9466bfe31788 100644
--- a/pkg/analyzer/test/src/task/strong/inferred_type_test.dart
+++ b/pkg/analyzer/test/src/task/strong/inferred_type_test.dart
@@ -846,8 +846,7 @@ class B<T> {
var t1 = new A()..b = /*info:INFERRED_TYPE_ALLOCATION*/new B(1);
var t2 = <B<int>>[/*info:INFERRED_TYPE_ALLOCATION*/new B(2)];
var t3 = /*info:INFERRED_TYPE_LITERAL*/[
- /*info:INFERRED_TYPE_ALLOCATION*/new
- /*error:TOP_LEVEL_TYPE_ARGUMENTS*/B(3)
+ /*info:INFERRED_TYPE_ALLOCATION*/new B(3)
];
''');
}
@@ -2407,16 +2406,16 @@ typedef List<int> G(double x);
/*=T*/ generic/*<T>*/(a(/*=T*/ _), b(/*=T*/ _)) => null;
-var v = /*error:TOP_LEVEL_TYPE_ARGUMENTS*/generic((F f) => null, (G g) => null);
+var v = generic((F f) => null, (G g) => null);
''');
var v = mainUnit.topLevelVariables[0];
- expect(v.type.toString(), 'dynamic');
+ expect(v.type.toString(), '(num) → List<int>');
}
test_infer_assignToIndex() async {
await checkFileElement(r'''
List<double> a = <double>[];
-var b = (/*error:TOP_LEVEL_UNSUPPORTED*/a[0] = 1.0);
+var b = (a[0] = 1.0);
''');
}
@@ -2425,14 +2424,14 @@ var b = (/*error:TOP_LEVEL_UNSUPPORTED*/a[0] = 1.0);
class A {
int f;
}
-var v_assign = (/*error:TOP_LEVEL_UNSUPPORTED*/new A().f = 1);
-var v_plus = (/*error:TOP_LEVEL_UNSUPPORTED*/new A().f += 1);
-var v_minus = (/*error:TOP_LEVEL_UNSUPPORTED*/new A().f -= 1);
-var v_multiply = (/*error:TOP_LEVEL_UNSUPPORTED*/new A().f *= 1);
-var v_prefix_pp = (++new A()./*error:TOP_LEVEL_INSTANCE_GETTER*/f);
-var v_prefix_mm = (--new A()./*error:TOP_LEVEL_INSTANCE_GETTER*/f);
-var v_postfix_pp = (new A()./*error:TOP_LEVEL_INSTANCE_GETTER*/f++);
-var v_postfix_mm = (new A()./*error:TOP_LEVEL_INSTANCE_GETTER*/f--);
+var v_assign = (new A().f = 1);
+var v_plus = (new A().f += 1);
+var v_minus = (new A().f -= 1);
+var v_multiply = (new A().f *= 1);
+var v_prefix_pp = (++new A().f);
+var v_prefix_mm = (--new A().f);
+var v_postfix_pp = (new A().f++);
+var v_postfix_mm = (new A().f--);
''');
}
@@ -2445,10 +2444,10 @@ class A {
class B {
A a;
}
-var v_prefix_pp = (++new B()./*error:TOP_LEVEL_INSTANCE_GETTER*/a);
-var v_prefix_mm = (--new B()./*error:TOP_LEVEL_INSTANCE_GETTER*/a);
-var v_postfix_pp = (new B()./*error:TOP_LEVEL_INSTANCE_GETTER*/a++);
-var v_postfix_mm = (new B()./*error:TOP_LEVEL_INSTANCE_GETTER*/a--);
+var v_prefix_pp = (++new B().a);
+var v_prefix_mm = (--new B().a);
+var v_postfix_pp = (new B().a++);
+var v_postfix_mm = (new B().a--);
''');
}
@@ -2458,9 +2457,9 @@ class A {
int f;
}
A a = new A();
-var b = (/*error:TOP_LEVEL_UNSUPPORTED*/a.f = 1);
+var b = (a.f = 1);
var c = 0;
-var d = (/*error:TOP_LEVEL_UNSUPPORTED*/c = 1);
+var d = (c = 1);
''');
}
@@ -4741,7 +4740,7 @@ T run<T>(T f()) {
void printRunning() { print("running"); }
var x = run<dynamic>(printRunning);
-var y = /*info:USE_OF_VOID_RESULT, error:TOP_LEVEL_TYPE_ARGUMENTS*/run(printRunning);
+var y = /*info:USE_OF_VOID_RESULT*/run(printRunning);
main() {
void printRunning() { print("running"); }
@@ -4757,7 +4756,7 @@ main() {
var x = unit.topLevelVariables[0];
var y = unit.topLevelVariables[1];
expect(x.type.toString(), 'dynamic');
- expect(y.type.toString(), 'dynamic');
+ expect(y.type.toString(), 'void');
}
}
@@ -4793,6 +4792,12 @@ class InferredTypeTest_Driver extends InferredTypeTest {
@failingTest
@override
+ test_genericMethods_usesGreatestLowerBound_comment_topLevel() async {
+ await super.test_genericMethods_usesGreatestLowerBound_comment_topLevel();
+ }
+
+ @failingTest
+ @override
test_listLiteralsCanInferNull_topLevel() =>
super.test_listLiteralsCanInferNull_topLevel();
@@ -4828,4 +4833,10 @@ class InferredTypeTest_Driver extends InferredTypeTest {
await super
.test_unsafeBlockClosureInference_functionCall_explicitTypeParam_viaExpr2_comment();
}
+
+ @failingTest
+ @override
+ test_voidReturnTypeSubtypesDynamic() async {
+ await super.test_voidReturnTypeSubtypesDynamic();
+ }
}
« no previous file with comments | « pkg/analyzer/test/src/task/dart_test.dart ('k') | pkg/analyzer/test/src/task/strong_mode_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698