Remove toplevel inference restriction hints, and restore as much

pkg/analyzer/test/src/summary/resynthesize_common.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.src.serialization.elements_test;
 
 import 'dart:async';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/standard_resolution_map.dart';
@@ skipping 1126 matching lines @@
     } else if (resynthesized is VoidTypeImpl && original is VoidTypeImpl) {
       expect(resynthesized, same(original));
     } else if (resynthesized is DynamicTypeImpl &&
         original is UndefinedTypeImpl) {
       // TODO(scheglov) In the strong mode constant variable like
       //  `var V = new Unresolved()` gets `UndefinedTypeImpl`, and it gets
       // `DynamicTypeImpl` in the spec mode.
     } else if (resynthesized is BottomTypeImpl && original is BottomTypeImpl) {
       expect(resynthesized, same(original));
     } else if (resynthesized.runtimeType != original.runtimeType) {
-      fail('Type mismatch: expected ${original.runtimeType},'
-          ' got ${resynthesized.runtimeType} ($desc)');
+      fail('Type mismatch: expected $original,'
+          ' got $resynthesized ($desc)');
     } else {
       fail('Unimplemented comparison for ${original.runtimeType}');
     }
   }
 
   void compareVariableElements(
       VariableElement resynthesized, VariableElement original, String desc) {
     compareElements(resynthesized, original, desc);
     compareTypes(resynthesized.type, original.type, '$desc.type');
     VariableElementImpl resynthesizedActual =
@@ skipping 2520 matching lines @@
 const v = 'abc'.length;
 ''');
     if (isStrongMode) {
       if (isSharedFrontEnd) {
         checkElementText(library, r'''
 const int v = 'abc'.
         length/*location: dart:core;String;length?*/;
 ''');
       } else {
         checkElementText(library, r'''
-const dynamic v/*error: instanceGetter*/ = 'abc'.
+const int v = 'abc'.
         length/*location: dart:core;String;length?*/;
 ''');
       }
     } else {
       checkElementText(library, r'''
 const dynamic v = 'abc'.
         length/*location: dart:core;String;length?*/;
 ''');
     }
   }
 
   test_const_length_ofTopLevelVariable() async {
     var library = await checkLibrary(r'''
 const String S = 'abc';
 const v = S.length;
 ''');
     if (isStrongMode) {
       if (isSharedFrontEnd) {
         checkElementText(library, r'''
 const String S = 'abc';
 const int v =
         S/*location: test.dart;S?*/.
         length/*location: dart:core;String;length?*/;
 ''');
       } else {
         checkElementText(library, r'''
 const String S = 'abc';
-const dynamic v/*error: instanceGetter*/ =
+const int v =
         S/*location: test.dart;S?*/.
         length/*location: dart:core;String;length?*/;
 ''');
       }
     } else {
       checkElementText(library, r'''
 const String S = 'abc';
 const dynamic v =
         S/*location: test.dart;S?*/.
         length/*location: dart:core;String;length?*/;
 ''');
     }
   }
 
   test_const_length_ofTopLevelVariable_imported() async {
     addLibrarySource('/a.dart', r'''
 const String S = 'abc';
 ''');
     var library = await checkLibrary(r'''
 import 'a.dart';
 const v = S.length;
 ''');
     if (isStrongMode) {
       checkElementText(library, r'''
 import 'a.dart';
-const dynamic v/*error: instanceGetter*/ =
+const int v =
         S/*location: a.dart;S?*/.
         length/*location: dart:core;String;length?*/;
 ''');
     } else {
       checkElementText(library, r'''
 import 'a.dart';
 const dynamic v =
         S/*location: a.dart;S?*/.
         length/*location: dart:core;String;length?*/;
 ''');
     }
   }
 
   test_const_length_ofTopLevelVariable_imported_withPrefix() async {
     addLibrarySource('/a.dart', r'''
 const String S = 'abc';
 ''');
     var library = await checkLibrary(r'''
 import 'a.dart' as p;
 const v = p.S.length;
 ''');
     if (isStrongMode) {
       checkElementText(library, r'''
 import 'a.dart' as p;
-const dynamic v/*error: instanceGetter*/ =
+const int v =
         p/*location: test.dart;p*/.
         S/*location: a.dart;S?*/.
         length/*location: dart:core;String;length?*/;
 ''');
     } else {
       checkElementText(library, r'''
 import 'a.dart' as p;
 const dynamic v =
         p/*location: test.dart;p*/.
         S/*location: a.dart;S?*/.
@@ skipping 1135 matching lines @@
       checkElementText(library, r'''
 enum E {
   synthetic final int index;
   synthetic static const List<E> values;
   static const E a;
   static const E b;
   static const E c;
 }
 final E vValue;
 final List<E> vValues;
-final dynamic vIndex/*error: instanceGetter*/;
+final int vIndex;
 ''');
     } else {
       checkElementText(library, r'''
 enum E {
   synthetic final int index;
   synthetic static const List<E> values;
   static const E a;
   static const E b;
   static const E c;
 }
@@ skipping 8235 matching lines @@
       fail('Unexpectedly tried to get unlinked summary for $uri');
     }
     return serializedUnit;
   }
 
   @override
   bool hasLibrarySummary(String uri) {
     return true;
   }
 }