Remove toplevel inference restriction hints, and restore as much

pkg/analyzer/lib/src/task/dart.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.task.dart;
 
 import 'dart:collection';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/standard_resolution_map.dart';
@@ skipping 3137 matching lines @@
 
   @override
   void internalPerform() {
     //
     // Prepare inputs.
     //
     CompilationUnit unit = getRequiredInput(UNIT_INPUT);
     TypeProvider typeProvider = getRequiredInput(TYPE_PROVIDER_INPUT);
 
     //
-    // Prepare fields for which inference should be disabled.
-    //
-    Set<FieldElement> fieldsWithDisabledInference = new Set<FieldElement>();
-    for (CompilationUnitMember classDeclaration in unit.declarations) {
-      if (classDeclaration is ClassDeclaration) {
-        for (ClassMember fieldDeclaration in classDeclaration.members) {
-          if (fieldDeclaration is FieldDeclaration) {
-            if (!fieldDeclaration.isStatic) {
-              for (VariableDeclaration field
-                  in fieldDeclaration.fields.variables) {
-                Expression initializer = field.initializer;
-                if (initializer != null &&
-                    !isValidForTypeInference(initializer)) {
-                  fieldsWithDisabledInference.add(field.element);
-                }
-              }
-            }
-          }
-        }
-      }
-    }
-
-    //
     // Infer instance members.
     //
     if (context.analysisOptions.strongMode) {
       var inheritanceManager = new InheritanceManager(
           resolutionMap.elementDeclaredByCompilationUnit(unit).library);
       InstanceMemberInferrer inferrer = new InstanceMemberInferrer(
-          typeProvider, (_) => inheritanceManager, fieldsWithDisabledInference,
+          typeProvider, (_) => inheritanceManager,
           typeSystem: context.typeSystem);
       inferrer.inferCompilationUnit(unit.element);
     }
     //
     // Record outputs.
     //
     outputs[RESOLVED_UNIT10] = unit;
     outputs[CREATED_RESOLVED_UNIT10] = true;
   }
 
@@ skipping 241 matching lines @@
     List<AnalysisError> errors = AnalysisError.NO_ERRORS;
     if (dependencyCycle == null && variable.hasImplicitType) {
       VariableDeclaration declaration = getDeclaration(unit);
       //
       // Re-resolve the variable's initializer so that the inferred types
       // of other variables will be propagated.
       //
       RecordingErrorListener errorListener = new RecordingErrorListener();
       Expression initializer = declaration.initializer;
 
-      DartType newType;
-      if (!isValidForTypeInference(initializer)) {
+      ResolutionContext resolutionContext =
+          ResolutionContextBuilder.contextFor(initializer);
+      ResolverVisitor visitor = new ResolverVisitor(
+          variable.library, variable.source, typeProvider, errorListener,
+          nameScope: resolutionContext.scope);
+      if (resolutionContext.enclosingClassDeclaration != null) {
+        visitor.prepareToResolveMembersInClass(
+            resolutionContext.enclosingClassDeclaration);
+      }
+      visitor.initForIncrementalResolution();
+      initializer.accept(visitor);
+      DartType newType = initializer.staticType;
+      if (newType == null || newType.isBottom || newType.isDartCoreNull) {
         newType = typeProvider.dynamicType;
-      } else {
-        ResolutionContext resolutionContext =
-            ResolutionContextBuilder.contextFor(initializer);
-        ResolverVisitor visitor = new ResolverVisitor(
-            variable.library, variable.source, typeProvider, errorListener,
-            nameScope: resolutionContext.scope);
-        if (resolutionContext.enclosingClassDeclaration != null) {
-          visitor.prepareToResolveMembersInClass(
-              resolutionContext.enclosingClassDeclaration);
-        }
-        visitor.initForIncrementalResolution();
-        initializer.accept(visitor);
-        newType = initializer.staticType;
-        if (newType == null || newType.isBottom || newType.isDartCoreNull) {
-          newType = typeProvider.dynamicType;
-        }
       }
 
       //
       // Record the type of the variable.
       //
       setFieldType(variable, newType);
       errors = getUniqueErrors(errorListener.errors);
     } else {
       // TODO(brianwilkerson) For now we simply don't infer any type for
       // variables or fields involved in a cycle. We could try to be smarter
@@ skipping 2390 matching lines @@
 
   @override
   bool moveNext() {
     if (_newSources.isEmpty) {
       return false;
     }
     currentTarget = _newSources.removeLast();
     return true;
   }
 }