Improve scheme validation check in NavigatorContentUtils

Improve scheme validation check in NavigatorContentUtils

Though r174748 added a test case to check if scheme contains colon,
it would be better if scheme contains colon explicitly. This cl checks
scheme contains colon. if so, this cl generates syntax error exception.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175104

[haraken, 2014-05-29 04:20:08]

https://codereview.chromium.org/298273008/diff/40001/LayoutTests/fast/dom/nav...
File
LayoutTests/fast/dom/navigatorcontentutils/is-protocol-handler-registered.html
(left):

https://codereview.chromium.org/298273008/diff/40001/LayoutTests/fast/dom/nav...
LayoutTests/fast/dom/navigatorcontentutils/is-protocol-handler-registered.html:31:
var invalid_schemes = ['mailto:', 'ssh:/', 'magnet:+', 'tel:sip'];

You removed these tests, but do we already have any test for a scheme that
contains colons?

[gyuyoung-inactive, 2014-05-29 05:01:35]

https://codereview.chromium.org/298273008/diff/40001/LayoutTests/fast/dom/nav...
File
LayoutTests/fast/dom/navigatorcontentutils/is-protocol-handler-registered.html
(left):

https://codereview.chromium.org/298273008/diff/40001/LayoutTests/fast/dom/nav...
LayoutTests/fast/dom/navigatorcontentutils/is-protocol-handler-registered.html:31:
var invalid_schemes = ['mailto:', 'ssh:/', 'magnet:+', 'tel:sip'];
On 2014/05/29 04:20:09, haraken wrote:
> 
> You removed these tests, but do we already have any test for a scheme that
> contains colons?

Oh, my mistake. isProtocolHandlerRegistered() also needs to check if scheme has
colon. Thank you pointing it out.

[haraken, 2014-05-29 12:57:29]

LGTM

[gyuyoung-inactive, 2014-05-29 13:18:43]

The CQ bit was checked by gyuyoung.kim@samsung.com

[commit-bot: I haz the power, 2014-05-29 13:19:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/298273008/60001

[gyuyoung-inactive, 2014-05-30 03:03:58]

The CQ bit was unchecked by gyuyoung.kim@samsung.com

[gyuyoung-inactive, 2014-05-30 03:04:03]

The CQ bit was checked by gyuyoung.kim@samsung.com

[commit-bot: I haz the power, 2014-05-30 03:05:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/298273008/60001

[gyuyoung-inactive, 2014-05-30 03:07:18]

The CQ bit was unchecked by gyuyoung.kim@samsung.com

[gyuyoung-inactive, 2014-05-30 04:17:52]

The CQ bit was checked by gyuyoung.kim@samsung.com

[commit-bot: I haz the power, 2014-05-30 04:20:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/298273008/60001

[commit-bot: I haz the power, 2014-05-30 04:21:53]

Change committed as 175104