LayoutTests/fast/dom/navigatorcontentutils/unregister-protocol-handler.html - Issue 298273008: Improve scheme validation check in NavigatorContentUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/navigatorcontentutils/unregister-protocol-handler.html

Issue 298273008: Improve scheme validation check in NavigatorContentUtils (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/navigatorcontentutils/register-protocol-handler.html ('k') | Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/navigatorcontentutils/unregister-protocol-handler.html

diff --git a/LayoutTests/fast/dom/navigatorcontentutils/unregister-protocol-handler.html b/LayoutTests/fast/dom/navigatorcontentutils/unregister-protocol-handler.html

index c56a2d6eeebaea225cbccb6e5b1310ce97543e2e..d930fd2c56f75a89e4f4a7f5e4b8bc0b44cdb372 100644

--- a/LayoutTests/fast/dom/navigatorcontentutils/unregister-protocol-handler.html

+++ b/LayoutTests/fast/dom/navigatorcontentutils/unregister-protocol-handler.html

@@ -53,15 +53,16 @@ var invalid_schemes = ['mailto:', 'ssh:/', 'magnet:+', 'tel:sip'];

invalid_schemes.forEach(function (scheme) {

var succeeded = false;

try {

- window.navigator.registerProtocolHandler(scheme, 'invalid scheme uri=%s', 'title');

+ window.navigator.unregisterProtocolHandler(scheme, 'invalid scheme uri=%s', 'title');

} catch (e) {

- succeeded = true;

+ succeeded = 'SyntaxError' == e.name;

+ errorMessage = e.message;

}

if (succeeded)

debug('Pass: Invalid scheme "' + scheme + '" falied.');

else

- debug('Fail: Invalid scheme "' + scheme + '" allowed.');

+ debug('Fail: Invalid scheme "' + scheme + '" allowed. Threw exception: "' + errorMessage + '".');

});

var invalid_urls = ["", "%S"];