Chromium Code Reviews Chromium Code Reviews
Issue 298273008:
Improve scheme validation check in NavigatorContentUtils (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html> | 2 <html> |
| 3 <head> | 3 <head> |
| 4 <script src="../../../resources/js-test.js"></script> | 4 <script src="../../../resources/js-test.js"></script> |
| 5 </head> | 5 </head> |
| 6 <body> | 6 <body> |
| 7 <p>This test makes sure that navigator.isProtocolHandlerRegistered throws the pr oper exceptions and returns the default state of handler.</p> | 7 <p>This test makes sure that navigator.isProtocolHandlerRegistered throws the pr oper exceptions and returns the default state of handler.</p> |
| 8 <pre id="console"></pre> | 8 <pre id="console"></pre> |
| 9 <script> | 9 <script> |
| 10 if (window.testRunner) | 10 if (window.testRunner) |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 21 window.navigator.isProtocolHandlerRegistered(protocol, invalidUrl); | 21 window.navigator.isProtocolHandlerRegistered(protocol, invalidUrl); |
| 22 succeeded = false; | 22 succeeded = false; |
| 23 } catch (e) { | 23 } catch (e) { |
| 24 succeeded = true; | 24 succeeded = true; |
| 25 } | 25 } |
| 26 if (succeeded) | 26 if (succeeded) |
| 27 debug('PASS Invalid url "' + invalidUrl + '" threw SyntaxError exception.'); | 27 debug('PASS Invalid url "' + invalidUrl + '" threw SyntaxError exception.'); |
| 28 else | 28 else |
| 29 debug('FAIL Invalid url "' + invalidUrl + '" allowed.'); | 29 debug('FAIL Invalid url "' + invalidUrl + '" allowed.'); |
| 30 | 30 |
| 31 var invalid_schemes = ['mailto:', 'ssh:/', 'magnet:+', 'tel:sip']; | |
|
haraken
2014/05/29 04:20:09
You removed these tests, but do we already have an
gyuyoung-inactive
2014/05/29 05:01:36
Oh, my mistake. isProtocolHandlerRegistered() also
| |
| 32 invalid_schemes.forEach(function (scheme) { | |
| 33 var succeeded = false; | |
| 34 try { | |
| 35 window.navigator.registerProtocolHandler(scheme, 'invalid scheme uri=%s' , 'title'); | |
| 36 } catch (e) { | |
| 37 succeeded = true; | |
| 38 } | |
| 39 | |
| 40 if (succeeded) | |
| 41 debug('PASS Invalid scheme "' + scheme + '" falied.'); | |
| 42 else | |
| 43 debug('FAIL Invalid scheme "' + scheme + '" allowed.'); | |
| 44 }); | |
| 45 | |
| 46 // FIXME: Need to check if this function can return 'registered' and 'declined' states as well. | 31 // FIXME: Need to check if this function can return 'registered' and 'declined' states as well. |
| 47 try { | 32 try { |
| 48 var state = window.navigator.isProtocolHandlerRegistered("bitcoin", "valid p rotocol %s"); | 33 var state = window.navigator.isProtocolHandlerRegistered("bitcoin", "valid p rotocol %s"); |
| 49 if (state == "new") | 34 if (state == "new") |
| 50 debug('PASS window.navigator.isProtocolHandlerRegistered returns "new" s tate'); | 35 debug('PASS window.navigator.isProtocolHandlerRegistered returns "new" s tate'); |
| 51 else | 36 else |
| 52 debug("FAIL window.navigator.isProtocolHandlerRegistered doesn't return the default state."); | 37 debug("FAIL window.navigator.isProtocolHandlerRegistered doesn't return the default state."); |
| 53 } catch (e) { | 38 } catch (e) { |
| 54 debug('FAIL window.navigator.isProtocolHandlerRegistered call is failed: "' + e.message + '".'); | 39 debug('FAIL window.navigator.isProtocolHandlerRegistered call is failed: "' + e.message + '".'); |
| 55 } | 40 } |
| 56 </script> | 41 </script> |
| 57 </body> | 42 </body> |
| 58 </html> | 43 </html> |
| OLD | NEW |
