Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2982083002: FrameIsCompleteAtIndex to FrameIsReceivedAtIndex (Closed)

Created:
3 years, 5 months ago by scroggo_chromium
Modified:
3 years, 5 months ago
CC:
chromium-reviews, jzern, krit, drott+blinkwatch_chromium.org, urvang, blink-reviews-platform-graphics_chromium.org, dshwang, skal, pdr+graphicswatchlist_chromium.org, fmalita+watch_chromium.org, Rik, Justin Novosad, blink-reviews, kinuko+watch, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

FrameIsCompleteAtIndex to FrameIsReceivedAtIndex This method actually returns whether the encoded data for the frame at |index| has been fully received. (Prior to crrev.com/2879123003, the behavior was different for single-frame images versus multi-frame images. Now both return whether the frame is received.) Rename the method to better reflect its use, and avoid confusion in the future. No change in behavior, no new tests. Bug: 722168 Review-Url: https://codereview.chromium.org/2982083002 Cr-Commit-Position: refs/heads/master@{#487287} Committed: https://chromium.googlesource.com/chromium/src/+/19d792a377d6854e46acb0fd786b48f0690ad9d1

Patch Set 1 #

Patch Set 2 : Fix MockImageDecoder #

Patch Set 3 : Update upstack from ImageDecoder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -65 lines) Patch
M third_party/WebKit/Source/platform/graphics/BitmapImage.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImage.cpp View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp View 1 2 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp View 1 2 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageSource.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageSource.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoderTest.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
scroggo_chromium
3 years, 5 months ago (2017-07-17 19:25:18 UTC) #3
Peter Kasting
RS LGTM
3 years, 5 months ago (2017-07-17 19:30:56 UTC) #4
scroggo_chromium
Florin, can you look at the graphics changes?
3 years, 5 months ago (2017-07-17 20:33:48 UTC) #6
f(malita)
lgtm
3 years, 5 months ago (2017-07-17 20:37:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2982083002/40001
3 years, 5 months ago (2017-07-17 20:41:59 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-17 23:52:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/19d792a377d6854e46acb0fd786b...

Powered by Google App Engine
This is Rietveld 408576698