third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp - Issue 2982083002: FrameIsCompleteAtIndex to FrameIsReceivedAtIndex

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

Issue 2982083002: FrameIsCompleteAtIndex to FrameIsReceivedAtIndex (Closed)

Patch Set: Update upstack from ImageDecoder Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

index 05e56e9fe808901aacc44a3de7a9595af4e884da..8bc212a207852947356613291ae44839e7c45aa6 100644

--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

@@ -197,8 +197,8 @@ TEST(GIFImageDecoderTest, frameIsComplete) {

EXPECT_EQ(2u, decoder->FrameCount());

EXPECT_FALSE(decoder->Failed());

- EXPECT_TRUE(decoder->FrameIsCompleteAtIndex(0));

- EXPECT_TRUE(decoder->FrameIsCompleteAtIndex(1));

+ EXPECT_TRUE(decoder->FrameIsReceivedAtIndex(0));

+ EXPECT_TRUE(decoder->FrameIsReceivedAtIndex(1));

EXPECT_EQ(kAnimationLoopInfinite, decoder->RepetitionCount());

}

@@ -217,13 +217,13 @@ TEST(GIFImageDecoderTest, frameIsCompleteLoading) {

EXPECT_EQ(2u, decoder->FrameCount());

EXPECT_FALSE(decoder->Failed());

- EXPECT_TRUE(decoder->FrameIsCompleteAtIndex(0));

- EXPECT_FALSE(decoder->FrameIsCompleteAtIndex(1));

+ EXPECT_TRUE(decoder->FrameIsReceivedAtIndex(0));

+ EXPECT_FALSE(decoder->FrameIsReceivedAtIndex(1));

decoder->SetData(data_buffer.Get(), true);

EXPECT_EQ(2u, decoder->FrameCount());

- EXPECT_TRUE(decoder->FrameIsCompleteAtIndex(0));

- EXPECT_TRUE(decoder->FrameIsCompleteAtIndex(1));

+ EXPECT_TRUE(decoder->FrameIsReceivedAtIndex(0));

+ EXPECT_TRUE(decoder->FrameIsReceivedAtIndex(1));

}

TEST(GIFImageDecoderTest, badTerminator) {