third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h - Issue 2982083002: FrameIsCompleteAtIndex to FrameIsReceivedAtIndex

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

Issue 2982083002: FrameIsCompleteAtIndex to FrameIsReceivedAtIndex (Closed)

Patch Set: Update upstack from ImageDecoder Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

index dec862c04dd80bc31c93bb790634b522496d3a4c..54069d7b98c417e78eff4839e65c62644015efac 100644

--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

@@ -50,7 +50,7 @@ class PLATFORM_EXPORT GIFImageDecoder final : public ImageDecoder {

String FilenameExtension() const override { return "gif"; }

void OnSetData(SegmentReader* data) override;

int RepetitionCount() const override;

- bool FrameIsCompleteAtIndex(size_t) const override;

+ bool FrameIsReceivedAtIndex(size_t) const override;

float FrameDurationAtIndex(size_t) const override;

// CAUTION: SetFailed() deletes |reader_|. Be careful to avoid

// accessing deleted memory, especially when calling this from inside