Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2981713002: Revert of Allow presenting DXGI share handles as overlays. (Closed)

Created:
3 years, 5 months ago by jbauman
Modified:
3 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow presenting DXGI share handles as overlays. (patchset #5 id:80001 of https://codereview.chromium.org/2968503003/ ) Reason for revert: On NVIDIA drivers it causes an error - [396:4308:0711/184358.172:ERROR:direct_composition_surface_win.cc(640)] Error acquiring keyed mutex: 887a0001 See https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.gpu.fyi%2FWin10_Debug__NVIDIA_%2F1504%2F%2B%2Frecipes%2Fsteps%2Fpixel_test_on_NVIDIA_GPU_on_Windows_on_Windows-10%2F0%2Fstdout Original issue's description: > Allow presenting DXGI share handles as overlays. > > Create a new type of GLImage representing an NV12 DXGI share handle (and > array level) and support displaying it in an overlay. > > BUG=729238 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2968503003 > Cr-Commit-Position: refs/heads/master@{#485701} > Committed: https://chromium.googlesource.com/chromium/src/+/fc666dc7bc9d5141a6457ee08b0004c705463140 TBR=sunnyps@chromium.org,sandersd@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=729238 Review-Url: https://codereview.chromium.org/2981713002 Cr-Commit-Position: refs/heads/master@{#486128} Committed: https://chromium.googlesource.com/chromium/src/+/7d74c8949d47bf12272c0057d1656179349ee485

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -189 lines) Patch
M gpu/ipc/service/direct_composition_surface_win.cc View 4 chunks +2 lines, -23 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win_unittest.cc View 5 chunks +3 lines, -58 lines 0 comments Download
M media/gpu/dxva_picture_buffer_win.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M ui/gl/gl_image_dxgi.h View 4 chunks +9 lines, -35 lines 0 comments Download
M ui/gl/gl_image_dxgi.cc View 2 chunks +26 lines, -67 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jbauman
Created Revert of Allow presenting DXGI share handles as overlays.
3 years, 5 months ago (2017-07-12 22:07:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2981713002/1
3 years, 5 months ago (2017-07-12 22:08:03 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 22:08:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7d74c8949d47bf12272c0057d165...

Powered by Google App Engine
This is Rietveld 408576698