Allow presenting DXGI share handles as overlays.

Allow presenting DXGI share handles as overlays.

Create a new type of GLImage representing an NV12 DXGI share handle (and
array level) and support displaying it in an overlay.

BUG=729238
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2968503003
Cr-Original-Commit-Position: refs/heads/master@{#485701}
Committed: https://chromium.googlesource.com/chromium/src/+/fc666dc7bc9d5141a6457ee08b0004c705463140
Review-Url: https://codereview.chromium.org/2968503003
Cr-Commit-Position: refs/heads/master@{#488354}
Committed: https://chromium.googlesource.com/chromium/src/+/c4700d5a444904d53a5b576ff3cfb7fcff55890e

[jbauman, 2017-06-30 00:53:48]

Description was changed from

==========
Allow presenting DXGI share handles as overlays.

Create a new type of GLImage representing an NV12 DXGI share handle (and
array level) and support displaying it in an overlay.

BUG=
==========

to

==========
Allow presenting DXGI share handles as overlays.

Create a new type of GLImage representing an NV12 DXGI share handle (and
array level) and support displaying it in an overlay.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2017-06-30 00:53:54]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 00:54:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 01:31:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 01:31:47]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jbauman, 2017-06-30 02:04:17]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 02:04:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 04:12:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 04:12:57]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[jbauman, 2017-07-06 01:24:59]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 01:25:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 03:15:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 03:15:28]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-07-06 22:26:06]

Description was changed from

==========
Allow presenting DXGI share handles as overlays.

Create a new type of GLImage representing an NV12 DXGI share handle (and
array level) and support displaying it in an overlay.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Allow presenting DXGI share handles as overlays.

Create a new type of GLImage representing an NV12 DXGI share handle (and
array level) and support displaying it in an overlay.

BUG=729238
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2017-07-06 22:26:40]

jbauman@chromium.org changed reviewers:
+ sunnyps@chromium.org

[sunnyps, 2017-07-11 00:52:52]

I'm a bit confused about how these images will be shared. The code in
DirectCompositionSurface suggests that another device might have the resource
acquired and we wait for up to 1000ms for it. But shouldn't the other end have
already released the resource by the time ScheduleDCLayers etc. are called.

[jbauman, 2017-07-11 01:48:51]

On 2017/07/11 00:52:52, sunnyps wrote:
> I'm a bit confused about how these images will be shared. The code in
> DirectCompositionSurface suggests that another device might have the resource
> acquired and we wait for up to 1000ms for it. But shouldn't the other end have
> already released the resource by the time ScheduleDCLayers etc. are called.

The problem is that the keyed mutex is taken per-texture, not per-array-level.
Since the entire video is being decoded into different levels of one texture,
it's possible the producer will be decoding into a different array level at the
same time the consumer is trying to lock it to read from an older level. I
expect the video decoding and video processing calls should be really fast so
there won't be an issue in practice, but we want a delay to make sure it doesn't
accidentally skip frames.

If this turns out to be a problem we could use DXGI_RESOURCE_MISC_SHARED
instead, but that has difficulty with synchronization that I'd prefer to avoid.

[sunnyps, 2017-07-11 01:56:29]

lgtm % nit

https://codereview.chromium.org/2968503003/diff/40001/gpu/ipc/service/direct_...
File gpu/ipc/service/direct_composition_surface_win.cc (right):

https://codereview.chromium.org/2968503003/diff/40001/gpu/ipc/service/direct_...
gpu/ipc/service/direct_composition_surface_win.cc:622: if (keyed_mutex) {
nit: Can you add a comment about this?

[jbauman, 2017-07-11 03:46:14]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-11 03:46:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2017-07-11 03:46:43]

jbauman@chromium.org changed reviewers:
+ sandersd@chromium.org

[jbauman, 2017-07-11 03:46:44]

sandersd@, media/gpu OWNERS review.

[commit-bot: I haz the power, 2017-07-11 06:11:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 06:11:13]

Dry run: This issue passed the CQ dry run.

[sandersd (OOO until July 31), 2017-07-11 17:47:03]

media/ lgtm.

https://codereview.chromium.org/2968503003/diff/60001/media/gpu/dxva_picture_...
File media/gpu/dxva_picture_buffer_win.cc (right):

https://codereview.chromium.org/2968503003/diff/60001/media/gpu/dxva_picture_...
media/gpu/dxva_picture_buffer_win.cc:650:
static_cast<gl::GLImageDXGI*>(gl_image_.get());
Cast directly to CopyingGLImageDXGI here?

[jbauman, 2017-07-11 19:24:31]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2017-07-11 19:24:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
sunnyps@chromium.org, sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/2968503003/#ps80001
(title: "change cast")

[commit-bot: I haz the power, 2017-07-11 19:24:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-11 22:31:17]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499801071536430,
"parent_rev": "3fb847da9e4ea7d740f050b500c8bee941520ffa", "commit_rev":
"e072df78e45a1e01ae58b15cfcf8631ffa2f7aeb"}

[commit-bot: I haz the power, 2017-07-11 22:31:34]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499801071536430,
"parent_rev": "6800733941f0ecb0023cc873f573e6b62253e30c", "commit_rev":
"9c55dc68c453033f6d211731b77ee31966ebef8b"}

[commit-bot: I haz the power, 2017-07-11 22:31:51]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499801071536430,
"parent_rev": "a4f70af6616619e994d16b67f4fae8cc4ea2f155", "commit_rev":
"fc666dc7bc9d5141a6457ee08b0004c705463140"}

[commit-bot: I haz the power, 2017-07-11 22:32:06]

Description was changed from

==========
Allow presenting DXGI share handles as overlays.

Create a new type of GLImage representing an NV12 DXGI share handle (and
array level) and support displaying it in an overlay.

BUG=729238
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Allow presenting DXGI share handles as overlays.

Create a new type of GLImage representing an NV12 DXGI share handle (and
array level) and support displaying it in an overlay.

BUG=729238
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2968503003
Cr-Commit-Position: refs/heads/master@{#485701}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc666dc7bc9d5141a6457ee08b00...
==========

[commit-bot: I haz the power, 2017-07-11 22:32:07]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fc666dc7bc9d5141a6457ee08b00...

[jbauman, 2017-07-12 22:07:36]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2981713002/ by jbauman@chromium.org.

The reason for reverting is: On NVIDIA drivers it causes an error -
 [396:4308:0711/184358.172:ERROR:direct_composition_surface_win.cc(640)] Error
acquiring keyed mutex: 887a0001

See
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.gpu.fyi%2FWin10....

[jbauman, 2017-07-19 18:35:21]

Description was changed from

==========
Allow presenting DXGI share handles as overlays.

Create a new type of GLImage representing an NV12 DXGI share handle (and
array level) and support displaying it in an overlay.

BUG=729238
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2968503003
Cr-Commit-Position: refs/heads/master@{#485701}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc666dc7bc9d5141a6457ee08b00...
==========

to

==========
Allow presenting DXGI share handles as overlays.

Create a new type of GLImage representing an NV12 DXGI share handle (and
array level) and support displaying it in an overlay.

BUG=729238
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2968503003
Cr-Commit-Position: refs/heads/master@{#485701}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc666dc7bc9d5141a6457ee08b00...
==========

[jbauman, 2017-07-19 20:26:46]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-19 20:26:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-20 01:37:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-20 01:37:34]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-07-20 19:28:58]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2017-07-20 19:28:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
sunnyps@chromium.org, sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/2968503003/#ps120001
(title: "fix keyed mutex usage")

[commit-bot: I haz the power, 2017-07-20 19:29:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-20 19:36:20]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1500578938744230,
"parent_rev": "29786c71a84fc576bc6a861a1b91d830e2f686c9", "commit_rev":
"c4700d5a444904d53a5b576ff3cfb7fcff55890e"}

[commit-bot: I haz the power, 2017-07-20 19:36:42]

Description was changed from

==========
Allow presenting DXGI share handles as overlays.

Create a new type of GLImage representing an NV12 DXGI share handle (and
array level) and support displaying it in an overlay.

BUG=729238
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2968503003
Cr-Commit-Position: refs/heads/master@{#485701}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc666dc7bc9d5141a6457ee08b00...
==========

to

==========
Allow presenting DXGI share handles as overlays.

Create a new type of GLImage representing an NV12 DXGI share handle (and
array level) and support displaying it in an overlay.

BUG=729238
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2968503003
Cr-Original-Commit-Position: refs/heads/master@{#485701}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc666dc7bc9d5141a6457ee08b00...
Review-Url: https://codereview.chromium.org/2968503003
Cr-Commit-Position: refs/heads/master@{#488354}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4700d5a444904d53a5b576ff3cf...
==========

[commit-bot: I haz the power, 2017-07-20 19:36:43]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/c4700d5a444904d53a5b576ff3cf...