Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2980563002:
DevTools: remove unrestricted in console filter and group (Closed)
|
Created:
3 years, 5 months ago by luoe Modified:
3 years, 4 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: remove unrestricted in console filter and group
BUG=none
Review-Url: https://codereview.chromium.org/2980563002
Cr-Commit-Position: refs/heads/master@{#490060}
Committed: https://chromium.googlesource.com/chromium/src/+/56fbef3eb22b5385f10d430c3a8b4d7fb5f74f42
Patch Set 1 #Patch Set 2 : aaa #
Total comments: 2
Patch Set 3 : rebase #
Dependent Patchsets: Messages
Total messages: 25 (13 generated)
luoe@chromium.org changed reviewers: + allada@chromium.org, lushnikov@chromium.org
Please take a look. This CL is a preparation before fixing group filtering.
Patchset #2 (id:20001) has been deleted
https://codereview.chromium.org/2980563002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js (right): https://codereview.chromium.org/2980563002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:1284: constructor(options) { let's not have options object - just pass parameters in here
ptal https://codereview.chromium.org/2980563002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js (right): https://codereview.chromium.org/2980563002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:1284: constructor(options) { On 2017/07/17 22:47:38, lushnikov wrote: > let's not have options object - just pass parameters in here Done.
Patchset #3 (id:60001) has been deleted
lgtm
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CQ cannot get SignCLA result. Please try later.
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1501182402158910,
"parent_rev": "d4dba1055610269a26299a8ace1a54b0cabe4fd9", "commit_rev":
"c121c2ec00b2b3bb589cb56fbff62b6818d3ae20"}
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1501182402158910,
"parent_rev": "e0332327c4bf5e85e9aab3d38fa7cfe817fdcf25", "commit_rev":
"56fbef3eb22b5385f10d430c3a8b4d7fb5f74f42"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: remove unrestricted in console filter and group BUG=none ========== to ========== DevTools: remove unrestricted in console filter and group BUG=none Review-Url: https://codereview.chromium.org/2980563002 Cr-Commit-Position: refs/heads/master@{#490060} Committed: https://chromium.googlesource.com/chromium/src/+/56fbef3eb22b5385f10d430c3a8b... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as https://chromium.googlesource.com/chromium/src/+/56fbef3eb22b5385f10d430c3a8b... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
