Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2980563002: DevTools: remove unrestricted in console filter and group (Closed)
Patch Set: rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
index b41f100b86a2c206ae2ed666e778a5e0b226ade7..1ff7edd084e721664e7d035b8390dfcfa6cace57 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
@@ -477,7 +477,7 @@ Console.ConsoleView = class extends UI.VBox {
if (viewMessage.consoleMessage().type === ConsoleModel.ConsoleMessage.MessageType.EndGroup) {
if (lastMessage && !this._currentGroup.messagesHidden())
lastMessage.incrementCloseGroupDecorationCount();
- this._currentGroup = this._currentGroup.parentGroup();
+ this._currentGroup = this._currentGroup.parentGroup() || this._currentGroup;
return;
}
if (!this._currentGroup.messagesHidden()) {
@@ -978,9 +978,6 @@ Console.ConsoleView = class extends UI.VBox {
Console.ConsoleView.persistedHistorySize = 300;
-/**
- * @unrestricted
- */
Console.ConsoleViewFilter = class {
/**
* @param {function()} filterChangedCallback
@@ -1003,6 +1000,9 @@ Console.ConsoleViewFilter = class {
this._textFilterUI = new UI.ToolbarInput(Common.UIString('Filter'), 0.2, 1, true);
this._textFilterUI.addEventListener(UI.ToolbarInput.Event.TextChanged, this._textFilterChanged, this);
+ this._filterText = this._textFilterUI.value();
+ /** @type {?RegExp} */
+ this._filterRegex = null;
this._levelLabels = {};
this._levelLabels[ConsoleModel.ConsoleMessage.MessageLevel.Verbose] = Common.UIString('Verbose');
@@ -1247,9 +1247,6 @@ Console.ConsoleCommand = class extends Console.ConsoleViewMessage {
*/
Console.ConsoleCommand.MaxLengthToIgnoreHighlighter = 10000;
-/**
- * @unrestricted
- */
Console.ConsoleCommandResult = class extends Console.ConsoleViewMessage {
/**
* @param {!ConsoleModel.ConsoleMessage} message
@@ -1278,9 +1275,6 @@ Console.ConsoleCommandResult = class extends Console.ConsoleViewMessage {
}
};
-/**
- * @unrestricted
- */
Console.ConsoleGroup = class {
/**
* @param {?Console.ConsoleGroup} parentGroup
@@ -1318,14 +1312,12 @@ Console.ConsoleGroup = class {
* @return {?Console.ConsoleGroup}
*/
parentGroup() {
- return this._parentGroup || this;
+ return this._parentGroup;
}
};
-
/**
* @implements {UI.ActionDelegate}
- * @unrestricted
*/
Console.ConsoleView.ActionDelegate = class {
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698