DevTools: show all descendants if a console.group message title matches the filter

DevTools: show all descendants if a console.group message title matches the filter

If a console group has a title that matches the console text filter, it now
enables messages within the group to appear even if their text does not match.

Other filters such as level and execution context still take priority.

BUG=363796

[luoe, 2017-06-13 00:26:37]

Patchset #2 (id:20001) has been deleted

[luoe, 2017-06-13 00:27:08]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2017-06-13 00:27:08]

Please take a look

[luoe, 2017-06-13 02:47:09]

Description was changed from

==========
DevTools: show all descendants if a console.group message title matches the
filter

BUG=363796
==========

to

==========
DevTools: show all descendants if a console.group message title matches the
filter

BUG=363796
==========

[luoe, 2017-06-13 02:47:09]

luoe@chromium.org changed reviewers:
- lushnikov@chromium.org

[luoe, 2017-06-13 03:06:02]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2017-06-29 01:33:56]

luoe@chromium.org changed reviewers:
- lushnikov@chromium.org

[luoe, 2017-07-06 00:51:56]

Patchset #3 (id:60001) has been deleted

[luoe, 2017-07-06 00:52:03]

Patchset #2 (id:40001) has been deleted

[luoe, 2017-07-06 00:52:09]

Patchset #1 (id:1) has been deleted

[luoe, 2017-07-06 00:54:43]

Description was changed from

==========
DevTools: show all descendants if a console.group message title matches the
filter

BUG=363796
==========

to

==========
DevTools: show all descendants if a console.group message title matches the
filter

If a console group has a title that matches the console text filter, it now
enables messages within the group to appear even if their text does not match.

Other filters such as level and execution context still take priority.

BUG=363796
==========

[luoe, 2017-07-06 00:54:57]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2017-07-06 00:54:57]

Please take a look!

[luoe, 2017-07-06 01:16:48]

luoe@chromium.org changed reviewers:
+ allada@chromium.org

[luoe, 2017-07-17 21:54:46]

Patchset #3 (id:120001) has been deleted

[luoe, 2017-07-17 23:52:25]

Patchset #3 (id:140001) has been deleted

[luoe, 2017-07-19 01:20:33]

luoe@chromium.org changed reviewers:
+ chenwilliam@chromium.org

[chenwilliam, 2017-07-20 00:22:33]

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/inspector/console/console-filter-groups-expected.txt
(right):

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/inspector/console/console-filter-groups-expected.txt:308:
>console-filter-groups.html:20 Collapsed inner group-D
Discussed in person: should search within collapsed console items (f/u CL?)

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/inspector/console/console-filter-groups.html
(right):

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/inspector/console/console-filter-groups.html:113:
var delimeter = viewMessage.consoleMessage().isGroupStartMessage() ? ">" : "";
nit: s/delimeter/delimiter

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/inspector/console/console-filter-groups.html:114:
var indent = "";
nit: var indent = " ".repeat(viewMessage.nestingLevel());

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:495:
ignoreTextFilter || (this._filter.hasFilterText() &&
this._filter.matchesTextOrRegex(viewMessage));
I don't think you need hasFilterText here because
this._filter.matchesTextOrRegex(viewMessage) will handle the case where there's
no filter query properly.

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:1200:
hasFilterText() {
seems confusing since filterText has two meanings in this method. Let's call it
hasFilterQuery()?

[luoe, 2017-07-20 20:59:03]

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/inspector/console/console-filter-groups-expected.txt
(right):

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/inspector/console/console-filter-groups-expected.txt:308:
>console-filter-groups.html:20 Collapsed inner group-D
On 2017/07/20 00:22:33, chenwilliam wrote:
> Discussed in person: should search within collapsed console items (f/u CL?)

Acknowledged.  Also commented in the crbug.com/363796 that we want this in a
followup.

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/inspector/console/console-filter-groups.html
(right):

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/inspector/console/console-filter-groups.html:113:
var delimeter = viewMessage.consoleMessage().isGroupStartMessage() ? ">" : "";
On 2017/07/20 00:22:33, chenwilliam wrote:
> nit: s/delimeter/delimiter

Done.

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/inspector/console/console-filter-groups.html:114:
var indent = "";
On 2017/07/20 00:22:33, chenwilliam wrote:
> nit: var indent = " ".repeat(viewMessage.nestingLevel());

Done.

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:495:
ignoreTextFilter || (this._filter.hasFilterText() &&
this._filter.matchesTextOrRegex(viewMessage));
On 2017/07/20 00:22:33, chenwilliam wrote:
> I don't think you need hasFilterText here because
> this._filter.matchesTextOrRegex(viewMessage) will handle the case where
there's
> no filter query properly.

Done.

https://codereview.chromium.org/2939473002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:1200:
hasFilterText() {
On 2017/07/20 00:22:33, chenwilliam wrote:
> seems confusing since filterText has two meanings in this method. Let's call
it
> hasFilterQuery()?

Acknowledged.  Actually, per your previous comment, I only need hasFilterText()
once, so we can just inline it and remove this function.

[chenwilliam, 2017-07-20 21:39:03]

lgtm